From mboxrd@z Thu Jan 1 00:00:00 1970 From: Mark Brown Subject: Re: [PATCH 01/10] ASoC: core: Add snd_soc_dai_set_tdm_slot_xlate(). Date: Wed, 5 Mar 2014 14:30:15 +0800 Message-ID: <20140305063015.GA1704@sirena.org.uk> References: <1393387175-15539-1-git-send-email-Li.Xiubo@freescale.com> <1393387175-15539-2-git-send-email-Li.Xiubo@freescale.com> <5311DE70.7000901@metafoo.de> <20140305033935.GY13126@sirena.org.uk> <6991b4aaf2a34f8180b24f7a2ae8355a@BY2PR03MB505.namprd03.prod.outlook.com> Mime-Version: 1.0 Content-Type: multipart/mixed; boundary="===============2618556693710750641==" Return-path: Received: from mezzanine.sirena.org.uk (mezzanine.sirena.org.uk [106.187.55.193]) by alsa0.perex.cz (Postfix) with ESMTP id DA841265026 for ; Wed, 5 Mar 2014 07:36:46 +0100 (CET) In-Reply-To: <6991b4aaf2a34f8180b24f7a2ae8355a@BY2PR03MB505.namprd03.prod.outlook.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: alsa-devel-bounces@alsa-project.org Sender: alsa-devel-bounces@alsa-project.org To: "Li.Xiubo@freescale.com" Cc: "Fabio.Estevam@freescale.com" , "moinejf@free.fr" , "alsa-devel@alsa-project.org" , Lars-Peter Clausen , "kuninori.morimoto.gx@renesas.com" , "tiwai@suse.de" , "linux-kernel@vger.kernel.org" , "s.hauer@pengutronix.de" , "lgirdwood@gmail.com" , "timur@tabi.org" , "denis@eukrea.com" , "guangyu.chen@freescale.com" , "mpa@pengutronix.de" , "shawn.guo@linaro.org" List-Id: alsa-devel@alsa-project.org --===============2618556693710750641== Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="rwEMma7ioTxnRzrJ" Content-Disposition: inline --rwEMma7ioTxnRzrJ Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Wed, Mar 05, 2014 at 03:55:50AM +0000, Li.Xiubo@freescale.com wrote: > This adds the function of snd_soc_dai_set_tdm_slot_xlate, which is almost > One new signature of snd_soc_dai_set_tdm_slot discarding the mask > Parameters, which could be generated by itself. Right, so that's not a bad thing but the _xlate() naming is confusing - Lars' point was that if a function is called _xlate() it would usually be an operation used as part of DT parsing, not something called from non-DT code. The new interface is probably a good thing but needs a different name (perhaps _simple or something?) or we need to rename the old one out of the way (it's slightly less flexible so we probably don't want to remove it totally). > And I want to provide one standard method for the drivers who are parsing > The TDM information from the DT node.=20 This is a good goal. --rwEMma7ioTxnRzrJ Content-Type: application/pgp-signature; name="signature.asc" Content-Description: Digital signature -----BEGIN PGP SIGNATURE----- Version: GnuPG v2.0.22 (GNU/Linux) iQIcBAEBAgAGBQJTFsR0AAoJELSic+t+oim9nRgP/Rw0obl6L5b0lI0MbxJjCMT8 o4sxUT2d3HmLgJSrFOCt5g3Z5yoK0+tbCH1ID86FmgHh0hjNuw+WQR5gci1Rd2aO waKUk05MtT5GbeuV/9RZS3XIISxzWQHlJ8tfonWxfAPD02QlEa7MT5oPO4DqSGkM hq5/YekujQf5bu+TK08Vq4Tkc6ZTuauO1cDD+uHQ/b1tAPpuXprfXrLmy2yWd43Y gM6qygMWZio0aXi05EkJa8Saj3A/Rz/fxXNY8ddkPQv1bgqPNUaPqfO3OdDNOZ6i ybgWMbJagmRH0m10hO9/38B2iD1f3oao7h3RrAH/n7qz5SFc5nzbCLQ6Y1Zxa47u JL0jr7tbHf1r5JzoG/r+AJ7RQpZQOANBLjv+qWFoD4aJ37Cj8GdwJoyngjxa5cQF 0NR3zWpWWJUyDTkx0h79O/gdelcUIVBf+AuBFbmrkobLY15VdE5jnMQCtFpp1duA Jc+ZwlQT2rfTbsrPUbyC8QSFgP65qg2431ZqATRv1/tbIIa6nZEQ8EirBt9ZG7kP p+l7RigcYJNat2k/xXEjR9oOGZ5VoKGG5Dm/MsB9o7rGQXkAIPAN95rVu7Cc4LKr DhpZtODxRemrQ1rg/K5zoyUepyLqgRB0W1yv3MOppt5OZ2QNNWTvI9A5sVaU0xhL g+UkIc11T1L5w7EvCAJs =HBoj -----END PGP SIGNATURE----- --rwEMma7ioTxnRzrJ-- --===============2618556693710750641== Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Disposition: inline --===============2618556693710750641==--