From: Mark Brown <broonie@kernel.org>
To: Lars-Peter Clausen <lars@metafoo.de>
Cc: Brian Austin <brian.austin@cirrus.com>,
Nicolin Chen <Guangyu.Chen@freescale.com>,
Paul.Handrigan@cirrus.com, robh+dt@kernel.org,
pawel.moll@arm.com, mark.rutland@arm.com,
ijc+devicetree@hellion.org.uk, galak@codeaurora.org,
rob@landley.net, lgirdwood@gmail.com, grant.likely@linaro.org,
devicetree@vger.kernel.org, linux-doc@vger.kernel.org,
linux-kernel@vger.kernel.org, alsa-devel@alsa-project.org
Subject: Re: [PATCH v2] ASoC: cs42888: Add codec driver support
Date: Tue, 11 Mar 2014 18:46:06 +0000 [thread overview]
Message-ID: <20140311184606.GW28112@sirena.org.uk> (raw)
In-Reply-To: <531F320E.70605@metafoo.de>
[-- Attachment #1: Type: text/plain, Size: 722 bytes --]
On Tue, Mar 11, 2014 at 04:55:58PM +0100, Lars-Peter Clausen wrote:
> On 03/11/2014 04:41 PM, Brian Austin wrote:
> >So WRT the CS42888, this is one device in a series of 2 devices that are
> >register compatible with the only difference being that the CS42488 has 2
> >extra ADC's. Same die and same DeviceID.
> >Would it make more sense to submit the driver with the extra ADC's to make
> >it feature complete for both devices? Wouldn't be odd to have 2 drivers that
> >do the same for 98% of the code.
> This should be in one driver. But support for the second device can
> always be added in a follow up patch.
Yes, we can add support later. It might be helpful to name the driver
with some generic name I guess.
[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 836 bytes --]
next prev parent reply other threads:[~2014-03-11 18:46 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-03-11 11:19 [PATCH v2] ASoC: cs42888: Add codec driver support Nicolin Chen
2014-03-11 11:30 ` Mark Rutland
2014-03-11 11:11 ` Nicolin Chen
[not found] ` <1394536791-8381-1-git-send-email-Guangyu.Chen-KZfg59tc24xl57MIdRCFDg@public.gmane.org>
2014-03-11 15:41 ` Brian Austin
2014-03-11 15:55 ` Lars-Peter Clausen
2014-03-11 18:46 ` Mark Brown [this message]
2014-03-12 1:54 ` Nicolin Chen
2014-03-12 2:05 ` Austin, Brian
2014-03-12 2:03 ` Nicolin Chen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140311184606.GW28112@sirena.org.uk \
--to=broonie@kernel.org \
--cc=Guangyu.Chen@freescale.com \
--cc=Paul.Handrigan@cirrus.com \
--cc=alsa-devel@alsa-project.org \
--cc=brian.austin@cirrus.com \
--cc=devicetree@vger.kernel.org \
--cc=galak@codeaurora.org \
--cc=grant.likely@linaro.org \
--cc=ijc+devicetree@hellion.org.uk \
--cc=lars@metafoo.de \
--cc=lgirdwood@gmail.com \
--cc=linux-doc@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mark.rutland@arm.com \
--cc=pawel.moll@arm.com \
--cc=rob@landley.net \
--cc=robh+dt@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox