From: Mark Brown <broonie@kernel.org>
To: Lars-Peter Clausen <lars@metafoo.de>
Cc: Rongjun Ying <rongjun.ying@csr.com>,
Barry Song <baohua@kernel.org>,
Liam Girdwood <lgirdwood@gmail.com>,
alsa-devel@alsa-project.org
Subject: Re: [PATCH 1/2] ASoC: sirf-audio-codec: Remove snd_soc_codec_set_cache_io() call
Date: Mon, 17 Mar 2014 16:53:35 +0000 [thread overview]
Message-ID: <20140317165335.GU11706@sirena.org.uk> (raw)
In-Reply-To: <1394785572-28315-1-git-send-email-lars@metafoo.de>
[-- Attachment #1.1: Type: text/plain, Size: 500 bytes --]
On Fri, Mar 14, 2014 at 09:26:11AM +0100, Lars-Peter Clausen wrote:
> There was a overlap between the snd_soc_codec_set_cache_io() cleanup and the
> addition of the sirf-audio-codec resulting in the sirf-audio-codec driver still
> using the old signature of snd_soc_codec_set_cache_io(), which will cause a
> compile error. Since the core is able to automatically setup IO for this driver
> we can just remove both the snd_soc_set_cache_io() call and the control_data
> assignment.
Applied, thanks.
[-- Attachment #1.2: Digital signature --]
[-- Type: application/pgp-signature, Size: 836 bytes --]
[-- Attachment #2: Type: text/plain, Size: 0 bytes --]
prev parent reply other threads:[~2014-03-17 16:53 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-03-14 8:26 [PATCH 1/2] ASoC: sirf-audio-codec: Remove snd_soc_codec_set_cache_io() call Lars-Peter Clausen
2014-03-14 8:26 ` [PATCH 2/2] ASoC: sirf-audio-codec: Add missing Makefile entry Lars-Peter Clausen
2014-03-17 17:00 ` Mark Brown
2014-03-18 2:04 ` Rongjun Ying
2014-03-14 10:16 ` [PATCH 1/2] ASoC: sirf-audio-codec: Remove snd_soc_codec_set_cache_io() call Rongjun Ying
2014-03-14 10:21 ` Lars-Peter Clausen
2014-03-17 16:53 ` Mark Brown [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140317165335.GU11706@sirena.org.uk \
--to=broonie@kernel.org \
--cc=alsa-devel@alsa-project.org \
--cc=baohua@kernel.org \
--cc=lars@metafoo.de \
--cc=lgirdwood@gmail.com \
--cc=rongjun.ying@csr.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox