From: Mark Brown <broonie-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org>
To: Takashi Iwai <tiwai-l3A5Bk7waGM@public.gmane.org>
Cc: Lars-Peter Clausen <lars-Qo5EllUWu/uELgA04lAiVw@public.gmane.org>,
Dylan Reid <dgreid-F7+t8E8rja9g9hUCZPvPmw@public.gmane.org>,
abrestic-F7+t8E8rja9g9hUCZPvPmw@public.gmane.org,
swarren-3lzwWm7+Weoh9ZMKESR00Q@public.gmane.org,
linux-tegra-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
alsa-devel-K7yf7f+aM1XWsZ/bQMPhNw@public.gmane.org
Subject: Re: [PATCH v2 1/2] remgap: Fix possible sleep-in-atomic in regmap_bulk_write()
Date: Tue, 18 Mar 2014 20:21:54 +0000 [thread overview]
Message-ID: <20140318202154.GS11706@sirena.org.uk> (raw)
In-Reply-To: <s5hob13r5l6.wl%tiwai-l3A5Bk7waGM@public.gmane.org>
[-- Attachment #1: Type: text/plain, Size: 674 bytes --]
On Tue, Mar 18, 2014 at 02:36:53PM +0100, Takashi Iwai wrote:
> Mark Brown wrote:
> > > I thought of that, too, but didn't take it because covering the lock
> > > there doesn't change the fact that it's still fundamentally racy.
> > I'm not sure what you mean here - what do you mean yb "covering the
> > lock"?
> I meant covering memcpy() and parse_inplace() & co in the lock.
Oh, right. A fix is definitely needed and your fix is certainly good
from a correctness point of view but since we're narrowing the locked
region we may as well make it as small as possible while we're at it
both for comprehensibility ("why is that locked?") and performance.
[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 836 bytes --]
prev parent reply other threads:[~2014-03-18 20:21 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-03-18 11:58 [PATCH v2 1/2] remgap: Fix possible sleep-in-atomic in regmap_bulk_write() Takashi Iwai
[not found] ` <1395143914-26929-1-git-send-email-tiwai-l3A5Bk7waGM@public.gmane.org>
2014-03-18 11:58 ` [PATCH v2 2/2] remgap: Fix possible sleep-in-atomic in regmap_register_patch() Takashi Iwai
[not found] ` <1395143914-26929-2-git-send-email-tiwai-l3A5Bk7waGM@public.gmane.org>
2014-03-18 12:03 ` Mark Brown
2014-03-18 12:22 ` [PATCH v2 1/2] remgap: Fix possible sleep-in-atomic in regmap_bulk_write() Mark Brown
[not found] ` <20140318122218.GQ11706-GFdadSzt00ze9xe1eoZjHA@public.gmane.org>
2014-03-18 12:57 ` Takashi Iwai
[not found] ` <s5hr45zr7f1.wl%tiwai-l3A5Bk7waGM@public.gmane.org>
2014-03-18 13:04 ` Mark Brown
[not found] ` <20140318130426.GA11706-GFdadSzt00ze9xe1eoZjHA@public.gmane.org>
2014-03-18 13:36 ` Takashi Iwai
[not found] ` <s5hob13r5l6.wl%tiwai-l3A5Bk7waGM@public.gmane.org>
2014-03-18 20:21 ` Mark Brown [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140318202154.GS11706@sirena.org.uk \
--to=broonie-dgejt+ai2ygdnm+yrofe0a@public.gmane.org \
--cc=abrestic-F7+t8E8rja9g9hUCZPvPmw@public.gmane.org \
--cc=alsa-devel-K7yf7f+aM1XWsZ/bQMPhNw@public.gmane.org \
--cc=dgreid-F7+t8E8rja9g9hUCZPvPmw@public.gmane.org \
--cc=lars-Qo5EllUWu/uELgA04lAiVw@public.gmane.org \
--cc=linux-tegra-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=swarren-3lzwWm7+Weoh9ZMKESR00Q@public.gmane.org \
--cc=tiwai-l3A5Bk7waGM@public.gmane.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox