From: Mark Brown <broonie@kernel.org>
To: RongJun Ying <rjying@gmail.com>
Cc: alsa-devel@alsa-project.org, Takashi Iwai <tiwai@suse.de>,
Liam Girdwood <lgirdwood@gmail.com>,
workgroup.linux@csr.com, Rongjun Ying <rongjun.ying@csr.com>
Subject: Re: [PATCH 2/2] Documentation: Describe the SiRF audio hub Device Tree bindings
Date: Wed, 19 Mar 2014 18:55:47 +0000 [thread overview]
Message-ID: <20140319185547.GU11706@sirena.org.uk> (raw)
In-Reply-To: <1394707111-9539-3-git-send-email-rongjun.ying@csr.com>
[-- Attachment #1.1: Type: text/plain, Size: 664 bytes --]
On Thu, Mar 13, 2014 at 06:38:31PM +0800, RongJun Ying wrote:
> + audiocodec: audiocodec {
> + compatible = "sirf,atlas6-audio-codec";
> + interrupts = <35>;
> + clocks = <&clks 27>;
> + };
> +
> + audioport: audioport {
> + compatible = "sirf,audio-port";
> + i2s: i2s {
> + compatible = "sirf,prima2-i2s";
Given that this is all one single IP block which doesn't really exist
independently at the hardware level it shouldn't have separate nodes or
compatible strings for the functions at the DT level - that's all to do
with how Linux structures things, not about the hardware. As ever DT
should represent the hardware, not Linux's abstractions for it.
[-- Attachment #1.2: Digital signature --]
[-- Type: application/pgp-signature, Size: 836 bytes --]
[-- Attachment #2: Type: text/plain, Size: 0 bytes --]
prev parent reply other threads:[~2014-03-19 18:56 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-03-13 10:38 [PATCH 0/2] ASoC: sirf: Add sirf audio hub driver and use it RongJun Ying
2014-03-13 10:38 ` [PATCH 1/2] ASoC: sirf: Add sirf audio hub driver for sharing same register address space RongJun Ying
2014-03-19 18:25 ` Mark Brown
2014-03-13 10:38 ` [PATCH 2/2] Documentation: Describe the SiRF audio hub Device Tree bindings RongJun Ying
2014-03-19 18:55 ` Mark Brown [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140319185547.GU11706@sirena.org.uk \
--to=broonie@kernel.org \
--cc=alsa-devel@alsa-project.org \
--cc=lgirdwood@gmail.com \
--cc=rjying@gmail.com \
--cc=rongjun.ying@csr.com \
--cc=tiwai@suse.de \
--cc=workgroup.linux@csr.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox