From: Mark Brown <broonie@kernel.org>
To: Ben Dooks <ben.dooks@codethink.co.uk>
Cc: alsa-devel@alsa-project.org, kuninori.morimoto.gx@renesas.com,
lgirdwood@gmail.com, linux-sh@vger.kernel.org,
magnus.damm@opensource.se, linux-kernel@lists.codethink.co.uk,
William Towle <william.towle@codethink.co.uk>
Subject: Re: [PATCH] ASoC: rsnd: SSI needs to prepare clocks before enabling
Date: Sat, 29 Mar 2014 10:09:06 +0000 [thread overview]
Message-ID: <20140329100906.GE21628@sirena.org.uk> (raw)
In-Reply-To: <1396009626-24699-1-git-send-email-ben.dooks@codethink.co.uk>
[-- Attachment #1: Type: text/plain, Size: 733 bytes --]
On Fri, Mar 28, 2014 at 12:27:06PM +0000, Ben Dooks wrote:
> From: William Towle <william.towle@codethink.co.uk>
>
> The rsnd_ssi_hw_{stop|start} functions need to call clk_prepare_enable()
> and clk_disable_unprepare(), otherwise the following warning occurs on
> attempt to play sound:
This doesn't apply cleanly against current code, can you please check and
resend - I can't apply this anyway since...
> Signed-off-by: William Towle <william.towle@codethink.co.uk>
> [ben.dooks@codethink.co.uk: add more bug info to report]
> Tested-by: Ben Dooks <ben.dooks@codethink.co.uk>
> ---
...you forgot to sign off. I'm also not seeing the debug info you
mention in the changelog, indeed there's no error checking.
[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 836 bytes --]
next prev parent reply other threads:[~2014-03-29 10:09 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-03-28 12:27 [PATCH] ASoC: rsnd: SSI needs to prepare clocks before enabling Ben Dooks
2014-03-29 10:09 ` Mark Brown [this message]
2014-04-04 11:42 ` Ben Dooks
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140329100906.GE21628@sirena.org.uk \
--to=broonie@kernel.org \
--cc=alsa-devel@alsa-project.org \
--cc=ben.dooks@codethink.co.uk \
--cc=kuninori.morimoto.gx@renesas.com \
--cc=lgirdwood@gmail.com \
--cc=linux-kernel@lists.codethink.co.uk \
--cc=linux-sh@vger.kernel.org \
--cc=magnus.damm@opensource.se \
--cc=william.towle@codethink.co.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox