From: Mark Brown <broonie@kernel.org>
To: Nicolin Chen <Guangyu.Chen@freescale.com>
Cc: Brian Austin <brian.austin@cirrus.com>,
alsa-devel@alsa-project.org, Axel Lin <axel.lin@ingics.com>,
Liam Girdwood <lgirdwood@gmail.com>,
Paul Handrigan <Paul.Handrigan@cirrus.com>
Subject: Re: [PATCH] ASoC: cs42xx8: Check return value of regmap_read and report correct chipid value
Date: Thu, 3 Apr 2014 22:33:39 +0100 [thread overview]
Message-ID: <20140403213339.GA14763@sirena.org.uk> (raw)
In-Reply-To: <20140403153314.GB32327@MrMyself>
[-- Attachment #1.1: Type: text/plain, Size: 421 bytes --]
On Thu, Apr 03, 2014 at 11:33:15PM +0800, Nicolin Chen wrote:
> On Thu, Apr 03, 2014 at 03:53:36PM +0800, Axel Lin wrote:
> > + ret = regmap_read(cs42xx8->regmap, CS42XX8_CHIPID, &val);
> > + if (ret < 0) {
> > dev_err(dev, "failed to get device ID: %x", val);
> %d and ret would be better here since val won't be useful in this case.
Yes, they would - val won't have anything in particular in it if the I/O
fails.
[-- Attachment #1.2: Digital signature --]
[-- Type: application/pgp-signature, Size: 836 bytes --]
[-- Attachment #2: Type: text/plain, Size: 0 bytes --]
next prev parent reply other threads:[~2014-04-03 21:33 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-04-03 7:53 [PATCH] ASoC: cs42xx8: Check return value of regmap_read and report correct chipid value Axel Lin
2014-04-03 15:33 ` Nicolin Chen
2014-04-03 16:48 ` Paul Handrigan
2014-04-03 21:33 ` Mark Brown [this message]
2014-04-03 16:50 ` Brian Austin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140403213339.GA14763@sirena.org.uk \
--to=broonie@kernel.org \
--cc=Guangyu.Chen@freescale.com \
--cc=Paul.Handrigan@cirrus.com \
--cc=alsa-devel@alsa-project.org \
--cc=axel.lin@ingics.com \
--cc=brian.austin@cirrus.com \
--cc=lgirdwood@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox