From: Mark Brown <broonie@kernel.org>
To: Oder Chiou <oder_chiou@realtek.com>
Cc: bardliao@realtek.com, alsa-devel@alsa-project.org,
lgirdwood@gmail.com, flove@realtek.com
Subject: Re: [PATCH] ASoC: rt5640: add rt5639 support
Date: Tue, 8 Apr 2014 12:05:43 +0100 [thread overview]
Message-ID: <20140408110543.GC6518@sirena.org.uk> (raw)
In-Reply-To: <1396927929-31775-1-git-send-email-oder_chiou@realtek.com>
[-- Attachment #1.1: Type: text/plain, Size: 749 bytes --]
On Tue, Apr 08, 2014 at 11:32:09AM +0800, Oder Chiou wrote:
> -static const SOC_ENUM_SINGLE_DECL(rt5640_if1_dac_enum, RT5640_DIG_INF_DATA,
> - RT5640_IF1_DAC_SEL_SFT, rt5640_data_select);
> +static SOC_ENUM_SINGLE_DECL(rt5640_if1_dac_enum, RT5640_DIG_INF_DATA,
> + RT5640_IF1_DAC_SEL_SFT, rt5640_data_select);
This seems to contain a lot of changes like this which are purely coding
style changes rather than actual code changes. As far as I can tell the
majority of this change is coding style or comment changes. Can you
please split these out into separate commits, it is much harder to
review if it's hard to find the active changes. There's nothing wrong
with the stylistic stuff particularly but it should be done as separate
changes.
[-- Attachment #1.2: Digital signature --]
[-- Type: application/pgp-signature, Size: 836 bytes --]
[-- Attachment #2: Type: text/plain, Size: 0 bytes --]
next prev parent reply other threads:[~2014-04-08 11:05 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-04-08 3:32 [PATCH] ASoC: rt5640: add rt5639 support Oder Chiou
2014-04-08 11:05 ` Mark Brown [this message]
2014-04-08 11:33 ` Oder Chiou
-- strict thread matches above, loose matches on Subject: below --
2014-04-08 11:40 Oder Chiou
2014-04-08 20:21 ` Mark Brown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140408110543.GC6518@sirena.org.uk \
--to=broonie@kernel.org \
--cc=alsa-devel@alsa-project.org \
--cc=bardliao@realtek.com \
--cc=flove@realtek.com \
--cc=lgirdwood@gmail.com \
--cc=oder_chiou@realtek.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox