From: Mark Brown <broonie@kernel.org>
To: Lars-Peter Clausen <lars@metafoo.de>
Cc: Krzysztof Kozlowski <k.kozlowski@samsung.com>,
Liam Girdwood <lgirdwood@gmail.com>,
Jaroslav Kysela <perex@perex.cz>, Takashi Iwai <tiwai@suse.de>,
alsa-devel@alsa-project.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] ASoC: core: Fix Sparse incompatible types warning
Date: Wed, 9 Apr 2014 21:25:20 +0100 [thread overview]
Message-ID: <20140409202520.GQ6518@sirena.org.uk> (raw)
In-Reply-To: <53452F67.3060400@metafoo.de>
[-- Attachment #1: Type: text/plain, Size: 791 bytes --]
On Wed, Apr 09, 2014 at 01:30:47PM +0200, Lars-Peter Clausen wrote:
> On 04/09/2014 01:12 PM, Krzysztof Kozlowski wrote:
> >On śro, 2014-04-09 at 12:57 +0200, Lars-Peter Clausen wrote:
> >>On 04/09/2014 09:21 AM, Krzysztof Kozlowski wrote:
> >>>- buf_size = min(count, (sizeof(buf)-1));
> >>>+ buf_size = min(count, (size_t)(sizeof(buf)-1));
> >>But shouldn't the type of sizeof already be size_t?
> >Hmmm... yes it should. It looks like a false positive from Sparse so the
> >commit message should be rather "Suppress" than "Fix".
> I'm pretty sure it is a bug in sparse, we shouldn't suppress those, but
> rather fix them in sparse itself.
Either that or there's something else going on that hasn't been properly
understood. The above just looks completely bogus.
[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 836 bytes --]
next prev parent reply other threads:[~2014-04-09 20:25 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-04-09 7:21 [PATCH] ASoC: core: Fix Sparse incompatible types warning Krzysztof Kozlowski
2014-04-09 10:57 ` Lars-Peter Clausen
2014-04-09 11:12 ` Krzysztof Kozlowski
2014-04-09 11:30 ` Lars-Peter Clausen
2014-04-09 20:25 ` Mark Brown [this message]
2014-04-09 20:28 ` Lars-Peter Clausen
2014-04-10 3:01 ` Al Viro
2014-04-10 7:13 ` Krzysztof Kozlowski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140409202520.GQ6518@sirena.org.uk \
--to=broonie@kernel.org \
--cc=alsa-devel@alsa-project.org \
--cc=k.kozlowski@samsung.com \
--cc=lars@metafoo.de \
--cc=lgirdwood@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=perex@perex.cz \
--cc=tiwai@suse.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox