From: Mark Brown <broonie@kernel.org>
To: Xiang Xiao <xiaoxiang@xiaomi.com>
Cc: bardliao@realtek.com, alsa-devel@alsa-project.org, lgirdwood@gmail.com
Subject: Re: [PATCH] ASoC: dapm: don't skip evaluate the power of widget with force set
Date: Mon, 14 Apr 2014 21:36:46 +0100 [thread overview]
Message-ID: <20140414203646.GC25182@sirena.org.uk> (raw)
In-Reply-To: <1397378240-20821-1-git-send-email-xiaoxiang@xiaomi.com>
[-- Attachment #1.1: Type: text/plain, Size: 605 bytes --]
On Sun, Apr 13, 2014 at 04:37:20PM +0800, Xiang Xiao wrote:
> Signed-off-by: Xiang Xiao <xiaoxiang@xiaomi.com>
You should explain why you want to do this in the changelog - what's the
problem that's being fixed or benefit?
> - if (power != peer->power)
> + if (peer->force || power != peer->power)
> dapm_mark_dirty(peer, "peer state change");
This doesn't correspond to your changelog - it *will* skip evaluating
the widget power if the widget is forced. It's not clear why this would
be a benefit.
> - if (w->power == power)
> + if (!w->force && w->power == power)
> return;
Similarly here.
[-- Attachment #1.2: Digital signature --]
[-- Type: application/pgp-signature, Size: 836 bytes --]
[-- Attachment #2: Type: text/plain, Size: 0 bytes --]
prev parent reply other threads:[~2014-04-14 20:36 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-04-13 8:37 [PATCH] ASoC: dapm: don't skip evaluate the power of widget with force set Xiang Xiao
2014-04-14 20:36 ` Mark Brown [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140414203646.GC25182@sirena.org.uk \
--to=broonie@kernel.org \
--cc=alsa-devel@alsa-project.org \
--cc=bardliao@realtek.com \
--cc=lgirdwood@gmail.com \
--cc=xiaoxiang@xiaomi.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox