From: Mark Brown <broonie@kernel.org>
To: Nicolin Chen <Guangyu.Chen@freescale.com>
Cc: shawn.guo@linaro.org, linux-kernel@vger.kernel.org,
linuxppc-dev@lists.ozlabs.org, alsa-devel@alsa-project.org,
timur@tabi.org, Li.Xiubo@freescale.com,
linux-doc@vger.kernel.org, devicetree@vger.kernel.org,
rob@landley.net, galak@codeaurora.org,
ijc+devicetree@hellion.org.uk, mark.rutland@arm.com,
pawel.moll@arm.com, robh+dt@kernel.org
Subject: Re: [PATCH v2 1/2] ASoC: fsl_sai: Add clock controls for SAI
Date: Mon, 14 Apr 2014 21:43:31 +0100 [thread overview]
Message-ID: <20140414204331.GE25182@sirena.org.uk> (raw)
In-Reply-To: <12898efab7a5907e6ed1c438a486692f59ef9d8b.1396432924.git.Guangyu.Chen@freescale.com>
[-- Attachment #1: Type: text/plain, Size: 469 bytes --]
On Wed, Apr 02, 2014 at 06:10:19PM +0800, Nicolin Chen wrote:
> -- clock-names : Must include the "sai" entry.
> +- clock-names : Must include the "bus" for register access and "mclk1" "mclk2"
> + "mclk3" for bit clock and frame clock providing.
This breaks compatibilty with old DTs - it just removes the "sai" name.
It's OK to deprecate the "sai" clock name but you need to keep support
for DTs that only specify that, there's no code for that left in the
driver.
[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 836 bytes --]
next prev parent reply other threads:[~2014-04-14 20:43 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-04-02 10:10 [PATCH v2 0/2] ASoC: fsl_sai: Add bus clock and mclks with clock controls Nicolin Chen
2014-04-02 10:10 ` [PATCH v2 1/2] ASoC: fsl_sai: Add clock controls for SAI Nicolin Chen
2014-04-14 20:43 ` Mark Brown [this message]
2014-04-15 2:26 ` Nicolin Chen
2014-04-02 10:10 ` [PATCH v2 2/2] ARM: dts: Append clock bindings for sai2 on VF610 platform Nicolin Chen
2014-04-02 13:03 ` Shawn Guo
2014-04-02 13:39 ` Nicolin Chen
2014-04-04 9:52 ` Li.Xiubo
2014-04-14 20:38 ` Mark Brown
2014-04-15 2:28 ` Nicolin Chen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140414204331.GE25182@sirena.org.uk \
--to=broonie@kernel.org \
--cc=Guangyu.Chen@freescale.com \
--cc=Li.Xiubo@freescale.com \
--cc=alsa-devel@alsa-project.org \
--cc=devicetree@vger.kernel.org \
--cc=galak@codeaurora.org \
--cc=ijc+devicetree@hellion.org.uk \
--cc=linux-doc@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linuxppc-dev@lists.ozlabs.org \
--cc=mark.rutland@arm.com \
--cc=pawel.moll@arm.com \
--cc=rob@landley.net \
--cc=robh+dt@kernel.org \
--cc=shawn.guo@linaro.org \
--cc=timur@tabi.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox