From: Mark Brown <broonie@kernel.org>
To: Jyri Sarha <jsarha@ti.com>
Cc: moinejf@free.fr, alsa-devel@alsa-project.org,
kuninori.morimoto.gx@renesas.com, tiwai@suse.de,
lgirdwood@gmail.com, Nicolin Chen <Guangyu.Chen@freescale.com>
Subject: Re: [PATCH 1/3] ASoC: simple-card: Drop node->name checking
Date: Thu, 24 Apr 2014 14:03:41 +0100 [thread overview]
Message-ID: <20140424130341.GX12304@sirena.org.uk> (raw)
In-Reply-To: <535907FF.3040303@ti.com>
[-- Attachment #1.1: Type: text/plain, Size: 779 bytes --]
On Thu, Apr 24, 2014 at 03:47:59PM +0300, Jyri Sarha wrote:
> On 04/24/2014 02:13 PM, Nicolin Chen wrote:
Please delete unneeded context from your mails...
> >- if (!strcmp("sound", node->name))
> >- prefix = "simple-audio-card,";
> >+ prefix = "simple-audio-card,";
> I think you have missed the point of selecting the prefix based on the node
> name.
...
> Maybe the implementation could have been more explicit, but I think the old
> behavior is more convenient. If we anyway decide to go with this change then
> at least the DT binding document should be updated.
Yes, the implementation needs to be *way* more explicit - I'd expect a
parameter/variable saying which level we're at depending on where we're
at in the parse rather than guessing based on the node name.
[-- Attachment #1.2: Digital signature --]
[-- Type: application/pgp-signature, Size: 836 bytes --]
[-- Attachment #2: Type: text/plain, Size: 0 bytes --]
next prev parent reply other threads:[~2014-04-24 13:04 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-04-24 11:13 [PATCH 0/3] Fix some minor issues in simple card driver Nicolin Chen
2014-04-24 11:13 ` [PATCH 1/3] ASoC: simple-card: Drop node->name checking Nicolin Chen
2014-04-24 12:47 ` Jyri Sarha
2014-04-24 13:03 ` Mark Brown [this message]
2014-04-24 13:05 ` Jyri Sarha
2014-04-24 11:13 ` [PATCH 2/3] ASoC: simple-card: Simplify error msg in simple_card_dai_link_of() Nicolin Chen
2014-04-24 11:14 ` [PATCH 3/3] ASoC: simple-card: Improve coding style Nicolin Chen
2014-04-24 12:20 ` [PATCH 0/3] Fix some minor issues in simple card driver Mark Brown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140424130341.GX12304@sirena.org.uk \
--to=broonie@kernel.org \
--cc=Guangyu.Chen@freescale.com \
--cc=alsa-devel@alsa-project.org \
--cc=jsarha@ti.com \
--cc=kuninori.morimoto.gx@renesas.com \
--cc=lgirdwood@gmail.com \
--cc=moinejf@free.fr \
--cc=tiwai@suse.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox