From: Mark Brown <broonie@kernel.org>
To: Nicolin Chen <Guangyu.Chen@freescale.com>
Cc: tiwai@suse.de, alsa-devel@alsa-project.org, lgirdwood@gmail.com
Subject: Re: [PATCH 1/2] ASoC: fsl_spdif: Fix clock source for rxclk rate measurement
Date: Fri, 25 Apr 2014 17:10:15 +0100 [thread overview]
Message-ID: <20140425161015.GQ12304@sirena.org.uk> (raw)
In-Reply-To: <cbeb07fbdadd7bf72f74224d5ad12c9706376c95.1398427055.git.Guangyu.Chen@freescale.com>
[-- Attachment #1.1: Type: text/plain, Size: 473 bytes --]
On Fri, Apr 25, 2014 at 07:58:19PM +0800, Nicolin Chen wrote:
> + /* Get system clock for rx clock rate calculation */
> + sprintf(tmp, "rxtx%d", SPDIF_CLK_SRC_SYSCLK);
> + spdif_priv->sysclk = devm_clk_get(&pdev->dev, tmp);
> + if (IS_ERR(spdif_priv->sysclk)) {
> + dev_err(&pdev->dev, "no sys clock (%s) in devicetree\n", tmp);
> + return PTR_ERR(spdif_priv->sysclk);
> + }
> +
Why is this not just a fixed string - it seems like the clock name is a
constant anyway?
[-- Attachment #1.2: Digital signature --]
[-- Type: application/pgp-signature, Size: 836 bytes --]
[-- Attachment #2: Type: text/plain, Size: 0 bytes --]
next prev parent reply other threads:[~2014-04-25 16:10 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-04-25 11:58 [PATCH 0/2] Fix rxclk rate measurement Nicolin Chen
2014-04-25 11:58 ` [PATCH 1/2] ASoC: fsl_spdif: Fix clock source for " Nicolin Chen
2014-04-25 16:10 ` Mark Brown [this message]
2014-04-28 2:54 ` Nicolin Chen
2014-04-25 11:58 ` [PATCH 2/2] ASoC: fsl_spdif: Drop hard code in clk_get() for rxclk Nicolin Chen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140425161015.GQ12304@sirena.org.uk \
--to=broonie@kernel.org \
--cc=Guangyu.Chen@freescale.com \
--cc=alsa-devel@alsa-project.org \
--cc=lgirdwood@gmail.com \
--cc=tiwai@suse.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox