From: Mark Brown <broonie@kernel.org>
To: Bard Liao <bardliao@realtek.com>
Cc: Oder Chiou <oder_chiou@realtek.com>,
"alsa-devel@alsa-project.org" <alsa-devel@alsa-project.org>,
Stephen Warren <swarren@wwwdotorg.org>,
"lgirdwood@gmail.com" <lgirdwood@gmail.com>,
"jarkko.nikula@linux.intel.com" <jarkko.nikula@linux.intel.com>,
Flove <flove@realtek.com>
Subject: Re: [PATCH v2] ASoC: rt5640: Add minimal supportforRT5642
Date: Mon, 28 Apr 2014 09:52:45 +0100 [thread overview]
Message-ID: <20140428085245.GC15125@sirena.org.uk> (raw)
In-Reply-To: <ABFD875FF5FB574BA706497D987D48D73CE0EE@RTITMBSV03.realtek.com.tw>
[-- Attachment #1.1: Type: text/plain, Size: 656 bytes --]
On Sun, Apr 27, 2014 at 02:57:24PM +0000, Bard Liao wrote:
> > On 04/16/2014 08:24 PM, bardliao@realtek.com wrote:
> > Is this derived from Jarkko's patch? If so, shouldn't he be listed as
> > the author, not you? If it wasn't, then presumably his S-o-b line
> > shouldn't be in the patch description.
> I am sorry. I don't know the meaning of S-o-b's order.
It's not just the ordering, it's also the authorship information -
signed off by has a specific meaning about who wrote the code and
handing off responsibility for it which is important to licensing.
Adding a signoff for someone who didn't write the code is therefore
particularly problematic.
[-- Attachment #1.2: Digital signature --]
[-- Type: application/pgp-signature, Size: 836 bytes --]
[-- Attachment #2: Type: text/plain, Size: 0 bytes --]
prev parent reply other threads:[~2014-04-28 8:53 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-04-17 2:24 [PATCH v2] ASoC: rt5640: Add minimal support for RT5642 bardliao
2014-04-17 19:01 ` Mark Brown
2014-04-22 6:01 ` Jarkko Nikula
2014-04-22 11:53 ` Mark Brown
2014-04-22 14:14 ` Oder
2014-04-22 17:12 ` Mark Brown
2014-04-25 22:08 ` Stephen Warren
2014-04-26 0:22 ` Mark Brown
2014-04-28 6:47 ` Jarkko Nikula
2014-04-27 14:57 ` [PATCH v2] ASoC: rt5640: Add minimal supportforRT5642 Bard Liao
2014-04-28 8:52 ` Mark Brown [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140428085245.GC15125@sirena.org.uk \
--to=broonie@kernel.org \
--cc=alsa-devel@alsa-project.org \
--cc=bardliao@realtek.com \
--cc=flove@realtek.com \
--cc=jarkko.nikula@linux.intel.com \
--cc=lgirdwood@gmail.com \
--cc=oder_chiou@realtek.com \
--cc=swarren@wwwdotorg.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox