From mboxrd@z Thu Jan 1 00:00:00 1970 From: Mark Brown Subject: Re: [PATCH 11/15] ASoC: WM0010 needs SPI Date: Thu, 1 May 2014 12:08:42 -0700 Message-ID: <20140501190842.GZ3245@sirena.org.uk> References: <1398770316-19715-1-git-send-email-kaixu.xia@linaro.org> <1398770316-19715-12-git-send-email-kaixu.xia@linaro.org> Mime-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="VGJtZYeI3LbW67dD" Return-path: Content-Disposition: inline In-Reply-To: <1398770316-19715-12-git-send-email-kaixu.xia@linaro.org> Sender: linux-samsung-soc-owner@vger.kernel.org To: Xia Kaixu Cc: linux-kernel@vger.kernel.org, linaro-kernel@lists.linaro.org, arnd@arndb.de, Liam Girdwood , Ben Dooks , Kukjin Kim , Sangbeom Kim , alsa-devel@alsa-project.org, linux-arm-kernel@lists.infradead.org, linux-samsung-soc@vger.kernel.org List-Id: alsa-devel@alsa-project.org --VGJtZYeI3LbW67dD Content-Type: text/plain; charset=us-ascii Content-Disposition: inline On Tue, Apr 29, 2014 at 07:18:32PM +0800, Xia Kaixu wrote: > @@ -201,7 +201,7 @@ config SND_SOC_SPEYSIDE > select SND_SAMSUNG_I2S > select SND_SOC_WM8996 > select SND_SOC_WM9081 > - select SND_SOC_WM0010 > + select SND_SOC_WM0010 if SPI > select SND_SOC_WM1250_EV1 No, this is broken. The driver won't work if all the components it uses don't load and the dependency for SPI isn't SPI, it's SPI_MASTER. --VGJtZYeI3LbW67dD Content-Type: application/pgp-signature; name="signature.asc" Content-Description: Digital signature -----BEGIN PGP SIGNATURE----- Version: GnuPG v2.0.22 (GNU/Linux) iQIcBAEBAgAGBQJTYpu3AAoJELSic+t+oim9KJ4P/3LmQ+4hfHyEpaoZ1c5NtgIJ 2g3k6VLcChLiBKOKMh/Z4WRUZcF8PuQGkLj6hUHOwVIs6/j2FFJHjN5FMc6KGQ5s vvFx9e11SUWrufAzFZ2CuU1l2V0a0neGOpPKZlDUhOm7GM6ioUCbIAfyajHjKUp4 0seIH0VQiJ7g2mhksVGdqYRF9yAZxoihxzWHCARwu9zx7Zc9LCaMooLrUYK1tZiP VU6YB/0hxrhmWBdXcrTlTZ5+GI4O/kRRwBGabcowWiO28NhJF8P9yKJ8tyqHze41 Q4aQNMMX4Apb+nus489SvIYCu36KBCzrnSbhyP+wA86lj8xQ2GXtCh5mTxXKh3sm /zT6Xhh63sF7h2lTCSNCqUGtibPSi72zIuQD56wJXOcZSQ4PdgCDF+Q99r+UkJuo HHWPVX0YIBZ4KKZfaT7l7nMNekALMcuLMf2tqlrm94laQ6g2us+ilExL9tma5T/l gLyxRG11uwUU2rV/j87t2w7J3cHe0XdUxfj3GeqgtWR5wi24/jmGU/7Z2VSRiPDL vLSRL3M9UNTEobnCzHJRtCLXDagWUL6/WKdxYQY5wG2zRkW+CYgZL9RMlkhDqC20 8VaeXLMtV47htm6HDen1O+Hs0g+d3xt+eGi+7Bj7+WtIaCAjtqoTxBPk1CbzUC4P g6xIbzyGVg16+lU4/Hfu =8FMB -----END PGP SIGNATURE----- --VGJtZYeI3LbW67dD--