From: Mark Brown <broonie@kernel.org>
To: Lars-Peter Clausen <lars@metafoo.de>
Cc: alsa-devel@alsa-project.org, Liam Girdwood <lgirdwood@gmail.com>
Subject: Re: [PATCH 2/2] ASoC: dapm: Fix SUSPEND -> OFF bias sequence
Date: Mon, 5 May 2014 12:41:29 -0700 [thread overview]
Message-ID: <20140505194129.GT22111@sirena.org.uk> (raw)
In-Reply-To: <1399223826-28522-2-git-send-email-lars@metafoo.de>
[-- Attachment #1.1: Type: text/plain, Size: 591 bytes --]
On Sun, May 04, 2014 at 07:17:06PM +0200, Lars-Peter Clausen wrote:
> - /* Prepare for a STADDBY->ON or ON->STANDBY transition */
> - if (d->bias_level != d->target_bias_level) {
> + /* Prepare for a transition to ON or away from ON */
> + if ((d->target_bias_level == SND_SOC_BIAS_ON &&
> + d->bias_level != SND_SOC_BIAS_ON) ||
> + (d->target_bias_level != SND_SOC_BIAS_ON &&
> + d->bias_level == SND_SOC_BIAS_ON)) {
Can you fix the indentation so that the two sides of the or are lined
up? It's a bit of a fiddly test and having the two cases not lined up
makes it harder to read.
[-- Attachment #1.2: Digital signature --]
[-- Type: application/pgp-signature, Size: 836 bytes --]
[-- Attachment #2: Type: text/plain, Size: 0 bytes --]
next prev parent reply other threads:[~2014-05-06 0:59 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-05-04 17:17 [PATCH 1/2] ASoC: snd_soc_dapm_put_volsw: Make sure to always update the DAPM graph Lars-Peter Clausen
2014-05-04 17:17 ` [PATCH 2/2] ASoC: dapm: Fix SUSPEND -> OFF bias sequence Lars-Peter Clausen
2014-05-05 19:41 ` Mark Brown [this message]
2014-05-05 19:31 ` [PATCH 1/2] ASoC: snd_soc_dapm_put_volsw: Make sure to always update the DAPM graph Mark Brown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140505194129.GT22111@sirena.org.uk \
--to=broonie@kernel.org \
--cc=alsa-devel@alsa-project.org \
--cc=lars@metafoo.de \
--cc=lgirdwood@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox