Re: [PATCH v2] ASoC: rt5645: Add codec driver

[Mark Brown <broonie@kernel.org>]

[-- Attachment #1.1: Type: text/plain, Size: 1555 bytes --]

On Mon, May 05, 2014 at 11:15:24AM +0000, Oder Chiou wrote:
> > > +	/* I2S2 function select */
> > > +	SOC_SINGLE("I2S2 Func Switch", RT5645_GPIO_CTRL1, RT5645_I2S2_SEL_SFT,
> > > +		1, 1),

> > What functions is this switching?

> It is the pin share switch. The I2S data pins are the pin share to GPIO3/4/5/6.
> If we want to use the GPIO3/4/5/6, we need to set it. We will modify it using the
> platform data to set it.

Yes, please - this shouldn't be visible at runtime.

> > > +	/* TDM */
> > > +	SOC_ENUM("TDM Adc Slot0 1 Data", rt5645_tdm_adc_slot0_1_enum),
> > > +	SOC_ENUM("TDM Adc Slot2 3 Data", rt5645_tdm_adc_slot2_3_enum),
> > > +	SOC_ENUM("TDM Adc Slot4 5 Data", rt5645_tdm_adc_slot4_5_enum),
> > > +	SOC_ENUM("TDM Adc Slot6 7 Data", rt5645_tdm_adc_slot6_7_enum),
> > > +	SOC_ENUM("TDM IF1 ADC DATA Sel", rt5645_tdm_adc_sel_enum),
> > > +	SOC_SINGLE("TDM IF1_DAC1_L Sel", RT5645_TDM_CTRL_3, 12, 7, 0),
> > > +	SOC_SINGLE("TDM IF1_DAC1_R Sel", RT5645_TDM_CTRL_3, 8, 7, 0),
> > > +	SOC_SINGLE("TDM IF1_DAC2_L Sel", RT5645_TDM_CTRL_3, 4, 7, 0),
> > > +	SOC_SINGLE("TDM IF1_DAC2_R Sel", RT5645_TDM_CTRL_3, 0, 7, 0),

> > These look like they should be part of DAPM, they're about routing data as far as I
> > can tell.

> These are the data related controls with TDM function, not related the routing path.
> For instance, it likes the L and R channel data swap, or copy function.

These are very much routing controls - the routing operates at a mono
level.  Doing a left/right swap or stereo duplication of a mono control
is a routing thing.

[-- Attachment #1.2: Digital signature --]
[-- Type: application/pgp-signature, Size: 836 bytes --]

[-- Attachment #2: Type: text/plain, Size: 0 bytes --]