From: Mark Brown <broonie@kernel.org>
To: Daniel Mack <zonque@gmail.com>
Cc: alsa-devel@alsa-project.org
Subject: Re: [PATCH 2/2] ASoC: sta350: add support for bits in miscellaneous registers
Date: Mon, 5 May 2014 12:55:29 -0700 [thread overview]
Message-ID: <20140505195529.GZ22111@sirena.org.uk> (raw)
In-Reply-To: <1399283363-16441-2-git-send-email-zonque@gmail.com>
[-- Attachment #1.1: Type: text/plain, Size: 642 bytes --]
On Mon, May 05, 2014 at 11:49:23AM +0200, Daniel Mack wrote:
> Add support for RPDNEN, NSHHPEN, BRIDGOFF, CPWMEN and PNDLSL, and add DT
> bindings to access them.
Applied, thanks. However...
> + - st,powerdown-delay-divider:
> + If present, the bridge power-down time will be divided by the provided
> + value. If not specified, a divider of 1 will be used. Allowed values
> + are 1, 2, 4, 8, 16, 32, 64 and 128.
> + This property has to be specified as '/bits/ 8' value.
There doesn't seem to be a pressing need for this to be specified as
/bits/ 8? It makes the parsing marginally easier but doesn't seem
entirely helpful for users.
[-- Attachment #1.2: Digital signature --]
[-- Type: application/pgp-signature, Size: 836 bytes --]
[-- Attachment #2: Type: text/plain, Size: 0 bytes --]
next prev parent reply other threads:[~2014-05-06 0:56 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-05-05 9:49 [PATCH 1/2] ASoC: sta350: fix DT bindings document Daniel Mack
2014-05-05 9:49 ` [PATCH 2/2] ASoC: sta350: add support for bits in miscellaneous registers Daniel Mack
2014-05-05 19:55 ` Mark Brown [this message]
2014-05-05 19:52 ` [PATCH 1/2] ASoC: sta350: fix DT bindings document Mark Brown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140505195529.GZ22111@sirena.org.uk \
--to=broonie@kernel.org \
--cc=alsa-devel@alsa-project.org \
--cc=zonque@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox