Re: [PATCH 1/2] ASoC: Add support for CS42L56 CODEC

[Mark Brown <broonie-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org>]

[-- Attachment #1: Type: text/plain, Size: 847 bytes --]

On Mon, May 05, 2014 at 03:09:08PM -0500, Brian Austin wrote:
> This patch adds support for the Cirrus Logic Low Power Stereo I2C CODEC

Applied, thanks.  A couple of minor issues it'd be good to look at
incrementally.

> +	SOC_ENUM("PCMA Swap", pcma_swap_enum),
> +	SOC_ENUM("PCMB Swap", pcmb_swap_enum),
> +	SOC_ENUM("ADCA Swap", adca_swap_enum),
> +	SOC_ENUM("ADCB Swap", adcb_swap_enum),

Can these be moved to DAPM?

> +	regcache_cache_bypass(cs42l56->regmap, true);

You shouldn't need to do this, if no default is provided regmap should
just go to hardware.

> +	dev_info(&i2c_client->dev, "Cirrus Logic CS42L56 ");
> +	dev_info(&i2c_client->dev, "Alpha Rev %X Metal Rev %X\n",
> +		 alpha_rev, metal_rev);

It's better to just put things on one line and ignore the line length
warnings from checkpatch - this makes the code more grepable.

[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 836 bytes --]