Re: [RFC 3/4] ASoC: Intel: add the low level dsp driver for mrfld

[Vinod Koul <vinod.koul@intel.com>]

On Tue, May 06, 2014 at 04:45:52PM +0100, Liam Girdwood wrote:
> On Mon, 2014-05-05 at 23:31 +0530, Vinod Koul wrote:
> > This driver provides low level functions like sending and receiving IPCs, managing
> > power for DSP etc
> > 
> > Signed-off-by: Vinod Koul <vinod.koul@intel.com>
> > ---
> >  sound/soc/intel/sst/Makefile            |    5 +
> >  sound/soc/intel/sst/sst.c               |  631 ++++++++++++++++++++
> >  sound/soc/intel/sst/sst.h               |  686 ++++++++++++++++++++++
> >  sound/soc/intel/sst/sst_drv_interface.c |  812 ++++++++++++++++++++++++++
> >  sound/soc/intel/sst/sst_ipc.c           |  388 +++++++++++++
> >  sound/soc/intel/sst/sst_loader.c        |  947 +++++++++++++++++++++++++++++++
> >  sound/soc/intel/sst/sst_pvt.c           |  203 +++++++
> >  sound/soc/intel/sst/sst_stream.c        |  529 +++++++++++++++++
> 
> We should rename the sst directory to avoid confusion with other sst
> drivers.
Sure, any suggestion :D

> > +struct intel_sst_drv *sst_drv_ctx;
> 
> static ?
yup!

> 
> > +static struct mutex drv_ctx_lock;
> > +
> 
> 
> > +
> > +static int sst_save_dsp_context_v2(struct intel_sst_drv *sst)
> 
> Is there a V1 somewhere ?
Yes that was used in mfld driver. I dont think we will get around to push those
bits

> 
> 
> > +static int intel_sst_suspend(struct device *dev)
> > +{
> > +
> 
> extra line ? Spotted this in a few places too.
> 
> Probably best to split this into several patches to make review easier.
Okay will do that

-- 
~Vinod
> 
> Liam
> 

--