From: Mark Brown <broonie@kernel.org>
To: Bard Liao <bardliao@realtek.com>
Cc: Oder Chiou <oder_chiou@realtek.com>,
"alsa-devel@alsa-project.org" <alsa-devel@alsa-project.org>,
"lars@metafoo.de" <lars@metafoo.de>,
"lgirdwood@gmail.com" <lgirdwood@gmail.com>,
Gustaw Lewandowski <gustaw.lewandowski@intel.com>,
Flove <flove@realtek.com>
Subject: Re: [PATCH v6] ASoC: add RT286 CODEC driver
Date: Wed, 7 May 2014 18:21:13 +0100 [thread overview]
Message-ID: <20140507172113.GI22111@sirena.org.uk> (raw)
In-Reply-To: <ABFD875FF5FB574BA706497D987D48D73D68A0@RTITMBSV03.realtek.com.tw>
[-- Attachment #1.1: Type: text/plain, Size: 956 bytes --]
On Tue, May 06, 2014 at 12:04:27PM +0000, Bard Liao wrote:
> > -----Original Message-----
> > From: Mark Brown [mailto:broonie@kernel.org]
As I'm fairly sure has been requested before please fix your mailer to
word wrap within paragraphs, it is very hard to read your mails since
the lines are longer than 80 columns.
> Virtual controls assume there is no related register related to the controls, so codec
> doesn't need to set anything when the control's value is changed in general cases.
> But rt286 need to do something when the control's value is changed especially mux
> settings.
...
> Do you have any suggestion for setting corresponding registers of a
> virtual control?
Please extend the APIs for virtual controls if you find they are missing
things you need, they've not been widely used in this sort of context -
I think this is the first substantial device anyone has tried to merge
without a register map so it's likely there are gaps.
[-- Attachment #1.2: Digital signature --]
[-- Type: application/pgp-signature, Size: 836 bytes --]
[-- Attachment #2: Type: text/plain, Size: 0 bytes --]
next prev parent reply other threads:[~2014-05-07 17:22 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-04-14 5:59 [PATCH v6] ASoC: add RT286 CODEC driver bardliao
2014-04-15 12:04 ` Mark Brown
2014-04-16 13:26 ` Bard Liao
2014-04-16 21:11 ` Mark Brown
2014-04-17 5:39 ` Bard Liao
2014-04-18 10:37 ` Mark Brown
2014-05-06 12:04 ` Bard Liao
2014-05-07 17:21 ` Mark Brown [this message]
2014-05-07 17:46 ` Lars-Peter Clausen
2014-05-07 18:07 ` Mark Brown
2014-05-07 18:21 ` Lars-Peter Clausen
2014-05-07 19:49 ` Mark Brown
2014-05-08 7:05 ` Lars-Peter Clausen
2014-05-08 8:00 ` Mark Brown
2014-05-08 8:57 ` Lars-Peter Clausen
2014-05-12 11:08 ` Bard Liao
2014-05-12 14:51 ` Lars-Peter Clausen
2014-05-12 20:29 ` Mark Brown
2014-06-04 12:08 ` Bard Liao
2014-06-04 12:37 ` Mark Brown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140507172113.GI22111@sirena.org.uk \
--to=broonie@kernel.org \
--cc=alsa-devel@alsa-project.org \
--cc=bardliao@realtek.com \
--cc=flove@realtek.com \
--cc=gustaw.lewandowski@intel.com \
--cc=lars@metafoo.de \
--cc=lgirdwood@gmail.com \
--cc=oder_chiou@realtek.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox