From: Mark Brown <broonie@kernel.org>
To: Nicolin Chen <Guangyu.Chen@freescale.com>
Cc: tiwai@suse.de, alsa-devel@alsa-project.org, lgirdwood@gmail.com
Subject: Re: [PATCH 2/2] ASoC: fsl_spdif: Improve coding style
Date: Mon, 12 May 2014 23:12:10 +0100 [thread overview]
Message-ID: <20140512221210.GD12304@sirena.org.uk> (raw)
In-Reply-To: <1399365745-21116-1-git-send-email-Guangyu.Chen@freescale.com>
[-- Attachment #1.1: Type: text/plain, Size: 233 bytes --]
On Tue, May 06, 2014 at 04:42:25PM +0800, Nicolin Chen wrote:
> 1) Apply better indentations
> 2) Drop braces for single statement.
> 3) Use simpler ternary to reduce code.
Applied, thanks. It's better to do one change per commit.
[-- Attachment #1.2: Digital signature --]
[-- Type: application/pgp-signature, Size: 836 bytes --]
[-- Attachment #2: Type: text/plain, Size: 0 bytes --]
prev parent reply other threads:[~2014-05-12 22:12 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-05-06 8:42 [PATCH 2/2] ASoC: fsl_spdif: Improve coding style Nicolin Chen
2014-05-12 22:12 ` Mark Brown [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140512221210.GD12304@sirena.org.uk \
--to=broonie@kernel.org \
--cc=Guangyu.Chen@freescale.com \
--cc=alsa-devel@alsa-project.org \
--cc=lgirdwood@gmail.com \
--cc=tiwai@suse.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox