From: Charles Keepax <ckeepax@opensource.wolfsonmicro.com>
To: Lars-Peter Clausen <lars@metafoo.de>
Cc: Dimitris Papastamos <dp@opensource.wolfsonmicro.com>,
Linux-ALSA <alsa-devel@alsa-project.org>,
Mark Brown <broonie@kernel.org>,
patches@opensource.wolfsonmicro.com
Subject: Re: Broken outmixer_event function in wm8400/wm8990/wm8991
Date: Tue, 13 May 2014 15:22:22 +0100 [thread overview]
Message-ID: <20140513142222.GM25203@opensource.wolfsonmicro.com> (raw)
In-Reply-To: <537227F7.9000609@metafoo.de>
On Tue, May 13, 2014 at 04:11:03PM +0200, Lars-Peter Clausen wrote:
> On 05/13/2014 03:53 PM, Charles Keepax wrote:
>> On Mon, May 12, 2014 at 09:47:34PM +0100, Mark Brown wrote:
>>> On Mon, May 12, 2014 at 10:19:26AM +0200, Lars-Peter Clausen wrote:
>> I would be inclined to go with the custom put/get method as well,
>> but it leaves a question of what to do if the user sets an
>> invalid value. Refusing to set the control feels nicer, but adds
>> an ordering limitation on setting the controls. Updating the
>> conflicting control is also possible, but might be a little
>> surprising?
>
> The event PRE_REG event is generated as soon as the control is changed,
> not when the path powers up. So there is no difference to a custom put
> handler in this regard.
Right, thanks, in that case yeah I can see no reason not to
switch to a custom put. I will shove it on the todo list.
Thanks,
Charles
next prev parent reply other threads:[~2014-05-13 14:22 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-05-12 8:19 Broken outmixer_event function in wm8400/wm8990/wm8991 Lars-Peter Clausen
2014-05-12 20:47 ` Mark Brown
2014-05-13 13:53 ` Charles Keepax
2014-05-13 14:11 ` Lars-Peter Clausen
2014-05-13 14:22 ` Charles Keepax [this message]
2014-05-13 16:09 ` Mark Brown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140513142222.GM25203@opensource.wolfsonmicro.com \
--to=ckeepax@opensource.wolfsonmicro.com \
--cc=alsa-devel@alsa-project.org \
--cc=broonie@kernel.org \
--cc=dp@opensource.wolfsonmicro.com \
--cc=lars@metafoo.de \
--cc=patches@opensource.wolfsonmicro.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox