Alsa-Devel Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: Mark Brown <broonie@kernel.org>
To: Andrew Lunn <andrew@lunn.ch>
Cc: alsa-devel@alsa-project.org, Jason Cooper <jason@lakedaemon.net>,
	linux ARM <linux-arm-kernel@lists.infradead.org>
Subject: Re: [PATCH RFC 02/11] sound: ASoC: kirkwood: Remove unused drivers
Date: Tue, 27 May 2014 20:52:12 +0100	[thread overview]
Message-ID: <20140527195212.GE12304@sirena.org.uk> (raw)
In-Reply-To: <20140527181818.GK26379@lunn.ch>


[-- Attachment #1.1: Type: text/plain, Size: 1241 bytes --]

On Tue, May 27, 2014 at 08:18:18PM +0200, Andrew Lunn wrote:
> On Tue, May 27, 2014 at 07:00:47PM +0100, Mark Brown wrote:
> > On Tue, May 27, 2014 at 06:45:30PM +0200, Andrew Lunn wrote:

> > > This is an RFC patch, as it says in the Subject line, and the cover
> > > note. It is not intended to be applied yet. Please unapply it, and the
> > > other one in the series you have applied.

> > Eh?  I thought the discussion was that everything was OK and we were
> > going to go ahead with this approach.  Or to put it another way what's
> > wrong with this and what's expected to change?

> What is wrong is that the merge path for the first patch, which
> removes the boards making use of these drivers, has already closed for
> patches.  So we now have boards left in the tree with broken audio. We
> can leave it that way, because these boards are actually in the tree
> twice. One using DT, which will work as things are now, and old style
> board file boards which are broken.

OK, so another part of this is that you didn't send the first patch to
me so I didn't realise that the boards were still there.  TBH I'd have
expected that removal to just be going in independently of cleaning up
the drivers.

Anyway, I dropped the patches.

[-- Attachment #1.2: Digital signature --]
[-- Type: application/pgp-signature, Size: 836 bytes --]

[-- Attachment #2: Type: text/plain, Size: 0 bytes --]



  reply	other threads:[~2014-05-27 19:52 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <1400163836-9831-1-git-send-email-andrew@lunn.ch>
2014-05-15 14:23 ` [PATCH RFC 02/11] sound: ASoC: kirkwood: Remove unused drivers Andrew Lunn
2014-05-26 15:59   ` Mark Brown
2014-05-27 16:45     ` Andrew Lunn
2014-05-27 18:00       ` Mark Brown
2014-05-27 18:18         ` Andrew Lunn
2014-05-27 19:52           ` Mark Brown [this message]
2014-05-27 23:46             ` Jason Cooper
2014-05-15 14:23 ` [PATCH RFC 03/11] sound: ASoC: kirkwood: Remove ARCH_KIRKWOOD dependency Andrew Lunn
2014-05-15 22:01   ` Adam Baker
2014-05-15 22:17     ` Andrew Lunn
2014-05-26 15:59   ` Mark Brown

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20140527195212.GE12304@sirena.org.uk \
    --to=broonie@kernel.org \
    --cc=alsa-devel@alsa-project.org \
    --cc=andrew@lunn.ch \
    --cc=jason@lakedaemon.net \
    --cc=linux-arm-kernel@lists.infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox