From: Mark Brown <broonie@kernel.org>
To: Lars-Peter Clausen <lars@metafoo.de>
Cc: Brian Austin <brian.austin@cirrus.com>,
Kuninori Morimoto <kuninori.morimoto.gx@renesas.com>,
Liam Girdwood <lgirdwood@gmail.com>,
Paul Handrigan <Paul.Handrigan@cirrus.com>,
Peter Ujfalusi <peter.ujfalusi@ti.com>,
Jyri Sarha <jsarha@ti.com>,
alsa-devel@alsa-project.org,
Jarkko Nikula <jarkko.nikula@bitmer.com>
Subject: Re: [PATCH 5/5] ASoC: sh/fsi: Make one-bit bitfields unsigned
Date: Sat, 21 Jun 2014 21:02:28 +0100 [thread overview]
Message-ID: <20140621200228.GN5099@sirena.org.uk> (raw)
In-Reply-To: <1403163631-26215-6-git-send-email-lars@metafoo.de>
[-- Attachment #1.1: Type: text/plain, Size: 305 bytes --]
On Thu, Jun 19, 2014 at 09:40:31AM +0200, Lars-Peter Clausen wrote:
> One-bit signed bitfields have two possible values: 0 and -1. This sometimes
> leads to unexpected results (e.g. foo.bar = 1; foo.bar == 1 => false) which is
> why it is recommended to make one-bit bitfields unsigned.
Applied, thanks.
[-- Attachment #1.2: Digital signature --]
[-- Type: application/pgp-signature, Size: 819 bytes --]
[-- Attachment #2: Type: text/plain, Size: 0 bytes --]
prev parent reply other threads:[~2014-06-21 20:02 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-06-19 7:40 [PATCH 0/5] ASoC: Fix trival sparse warnings Lars-Peter Clausen
2014-06-19 7:40 ` [PATCH 1/5] ASoC: tlv320aic31xx: Remove duplicate const Lars-Peter Clausen
2014-06-21 19:57 ` Mark Brown
2014-06-19 7:40 ` [PATCH 2/5] ASoC: cs42xx8: Make of match table static Lars-Peter Clausen
2014-06-19 13:50 ` Brian Austin
2014-06-21 19:58 ` Mark Brown
2014-06-19 7:40 ` [PATCH 3/5] ASoC: omap-pcm: Include omap-pcm.h Lars-Peter Clausen
2014-06-21 20:00 ` Mark Brown
2014-06-30 16:48 ` Lars-Peter Clausen
2014-06-30 21:54 ` Mark Brown
2014-07-01 5:57 ` Lars-Peter Clausen
2014-06-19 7:40 ` [PATCH 4/5] ASoC: rcar: Fix dma direction type Lars-Peter Clausen
2014-06-19 9:12 ` Kuninori Morimoto
2014-06-19 9:24 ` Lars-Peter Clausen
2014-06-19 9:38 ` Kuninori Morimoto
2014-06-21 20:00 ` Mark Brown
2014-06-19 7:40 ` [PATCH 5/5] ASoC: sh/fsi: Make one-bit bitfields unsigned Lars-Peter Clausen
2014-06-19 9:12 ` Kuninori Morimoto
2014-06-21 20:02 ` Mark Brown [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140621200228.GN5099@sirena.org.uk \
--to=broonie@kernel.org \
--cc=Paul.Handrigan@cirrus.com \
--cc=alsa-devel@alsa-project.org \
--cc=brian.austin@cirrus.com \
--cc=jarkko.nikula@bitmer.com \
--cc=jsarha@ti.com \
--cc=kuninori.morimoto.gx@renesas.com \
--cc=lars@metafoo.de \
--cc=lgirdwood@gmail.com \
--cc=peter.ujfalusi@ti.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox