From: Mark Brown <broonie@kernel.org>
To: Charles Keepax <ckeepax@opensource.wolfsonmicro.com>
Cc: alsa-devel@alsa-project.org, patches@opensource.wolfsonmicro.com,
lee.jones@linaro.org, lgirdwood@gmail.com, sameo@linux.intel.com
Subject: Re: [PATCH 1/4 v2] mfd: arizona: Export function to control subsystem DVFS
Date: Sat, 21 Jun 2014 21:45:49 +0100 [thread overview]
Message-ID: <20140621204549.GA24291@sirena.org.uk> (raw)
In-Reply-To: <1403275273-22713-2-git-send-email-ckeepax@opensource.wolfsonmicro.com>
[-- Attachment #1.1: Type: text/plain, Size: 835 bytes --]
On Fri, Jun 20, 2014 at 03:41:10PM +0100, Charles Keepax wrote:
> + int ret = 0;
> + ret = regulator_set_voltage(arizona->dcvdd,
> + 1800000, 1800000);
> + if (ret != 0) {
> + dev_err(arizona->dev,
> + "Failed to raise dcvdd (%u)\n", ret);
> + goto err;
> + }
I'm really nitpicking here but the error code is a signed integer being
printed for some reason with %u and while I'm at it DCVDD would normally
be written in all caps for human consumption.
> +int arizona_dvfs_down(struct arizona *arizona, unsigned int flags)
> +{
> + int ret = 0;
> +
> + mutex_lock(&arizona->subsys_max_lock);
> +
> + arizona->subsys_max_rq &= ~flags;
Is it worth checking to see if the request was asserted and logging a
warning if it wasn't? The lack of refcounting suggests that a bit of
defensiveness might be in order.
[-- Attachment #1.2: Digital signature --]
[-- Type: application/pgp-signature, Size: 819 bytes --]
[-- Attachment #2: Type: text/plain, Size: 0 bytes --]
next prev parent reply other threads:[~2014-06-21 20:46 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-06-20 14:41 [PATCH 0/4 v2] arizona: Improvements to codec DVFS control Charles Keepax
2014-06-20 14:41 ` [PATCH 1/4 v2] mfd: arizona: Export function to control subsystem DVFS Charles Keepax
2014-06-21 20:45 ` Mark Brown [this message]
2014-06-23 15:38 ` Charles Keepax
2014-06-20 14:41 ` [PATCH 2/4 v2] ASoC: wm_adsp: Move DVFS control into codec driver Charles Keepax
2014-06-21 20:50 ` Mark Brown
2014-06-23 15:41 ` Charles Keepax
2014-06-20 14:41 ` [PATCH 3/4 v2] ASoC: arizona: Add DVFS handling for sample rate control Charles Keepax
2014-06-21 20:51 ` Mark Brown
2014-06-20 14:41 ` [PATCH 4/4 v2] regulator: arizona-ldo1: Do not control clocking from regulator Charles Keepax
2014-06-21 20:53 ` Mark Brown
2014-06-23 15:53 ` Charles Keepax
2014-06-23 16:29 ` Charles Keepax
2014-06-23 16:35 ` Mark Brown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140621204549.GA24291@sirena.org.uk \
--to=broonie@kernel.org \
--cc=alsa-devel@alsa-project.org \
--cc=ckeepax@opensource.wolfsonmicro.com \
--cc=lee.jones@linaro.org \
--cc=lgirdwood@gmail.com \
--cc=patches@opensource.wolfsonmicro.com \
--cc=sameo@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox