From: Charles Keepax <ckeepax@opensource.wolfsonmicro.com>
To: Lars-Peter Clausen <lars@metafoo.de>
Cc: andy.green@linaro.org, Xavier Hsu <xavier.hsu@linaro.org>,
alsa-devel@alsa-project.org, patches@opensource.wolfsonmicro.com,
patches@linaro.org
Subject: Re: [PATCH] ASoC: add Wolfson WM8973 codec driver
Date: Tue, 1 Jul 2014 12:05:00 +0100 [thread overview]
Message-ID: <20140701110500.GA19534@opensource.wolfsonmicro.com> (raw)
In-Reply-To: <53AD7ABB.7010201@metafoo.de>
On Fri, Jun 27, 2014 at 04:07:55PM +0200, Lars-Peter Clausen wrote:
> On 06/27/2014 09:09 AM, Xavier Hsu wrote:
>> This patch adds support for the wm8973 codec, based on the
>> existing wm8971 codec driver.
>>
>
> Those two look really similar. Do you think they can both be supported by
> the same driver, rather than duplicating most of the code?
>
> - Lars
I am not super familiar with these two devices but looking
through the two datasheets it certainly seems they should be
supported by the same driver. I would like to see some reason if
we were to not go down this route.
Thanks,
Charles
next prev parent reply other threads:[~2014-07-01 11:05 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-06-27 7:09 [PATCH] ASoC: add Wolfson WM8973 codec driver Xavier Hsu
2014-06-27 14:07 ` Lars-Peter Clausen
2014-07-01 11:05 ` Charles Keepax [this message]
2014-07-02 1:24 ` Xavier Hsu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140701110500.GA19534@opensource.wolfsonmicro.com \
--to=ckeepax@opensource.wolfsonmicro.com \
--cc=alsa-devel@alsa-project.org \
--cc=andy.green@linaro.org \
--cc=lars@metafoo.de \
--cc=patches@linaro.org \
--cc=patches@opensource.wolfsonmicro.com \
--cc=xavier.hsu@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).