Alsa-Devel Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: Charles Keepax <ckeepax@opensource.wolfsonmicro.com>
To: Mark Brown <broonie@kernel.org>
Cc: Vinod Koul <vinod.koul@intel.com>,
	alsa-devel@alsa-project.org, patches@opensource.wolfsonmicro.com,
	Praveen Diwakar <praveen.diwakar@intel.com>,
	lgirdwood@gmail.com
Subject: Re: [PATCH] ASoC: wm-adsp: Add missing MODULE_LICENSE
Date: Fri, 4 Jul 2014 13:47:24 +0100	[thread overview]
Message-ID: <20140704124724.GA16644@opensource.wolfsonmicro.com> (raw)
In-Reply-To: <20140704114723.GB19453@sirena.org.uk>

On Fri, Jul 04, 2014 at 12:47:23PM +0100, Mark Brown wrote:
> On Fri, Jul 04, 2014 at 11:17:41AM +0530, Vinod Koul wrote:
> > From: Praveen Diwakar <praveen.diwakar@intel.com>
> > 
> > Since MODULE_LICENSE is missing the module load fails,
> > so add this for module.
> 
> Always CC maintainers on patches (in this case the Wolfson people),
> especially for something like licensing.

Indeed we would definitely like to be in the loop on licensing
changes :-)

> 
> > Signed-off-by: Praveen Diwakar <praveen.diwakar@intel.com>
> > Signed-off-by: Vinod Koul <vinod.koul@intel.com>
> > ---
> > ---
> >  sound/soc/codecs/wm_adsp.c |    2 ++
> >  1 files changed, 2 insertions(+), 0 deletions(-)
> > 
> > diff --git a/sound/soc/codecs/wm_adsp.c b/sound/soc/codecs/wm_adsp.c
> > index 0600271..2537725 100644
> > --- a/sound/soc/codecs/wm_adsp.c
> > +++ b/sound/soc/codecs/wm_adsp.c
> > @@ -1758,3 +1758,5 @@ int wm_adsp2_init(struct wm_adsp *adsp, bool dvfs)
> >  	return 0;
> >  }
> >  EXPORT_SYMBOL_GPL(wm_adsp2_init);
> > +
> > +MODULE_LICENSE("GPL v2");

Yeah this is fine, I have been meaning to do that myself.

Reviewed-by: Charles Keepax <ckeepax@opensource.wolfsonmicro.com>

Thanks,
Charles

  reply	other threads:[~2014-07-04 12:47 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-07-04  5:47 [PATCH] ASoC: wm-adsp: Add missing MODULE_LICENSE Vinod Koul
2014-07-04 11:47 ` Mark Brown
2014-07-04 12:47   ` Charles Keepax [this message]
2014-07-09 16:39     ` Vinod Koul
2014-07-04 16:53 ` Mark Brown

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20140704124724.GA16644@opensource.wolfsonmicro.com \
    --to=ckeepax@opensource.wolfsonmicro.com \
    --cc=alsa-devel@alsa-project.org \
    --cc=broonie@kernel.org \
    --cc=lgirdwood@gmail.com \
    --cc=patches@opensource.wolfsonmicro.com \
    --cc=praveen.diwakar@intel.com \
    --cc=vinod.koul@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox