Re: [PATCH 2/4] ASoC: s3c64xx/smartq: use dynamic registration

[Mark Brown <broonie@kernel.org>]

[-- Attachment #1.1: Type: text/plain, Size: 1202 bytes --]

On Sun, Jul 13, 2014 at 03:36:52PM +0200, Lars-Peter Clausen wrote:
> On 07/12/2014 09:49 PM, Mark Brown wrote:

> >OTOH that's a more invasive change that's harder to do mechanically -
> >I'm not sure it's sensible to insist on someone doing it for generic
> >cleanups (rather than actively working with the particular platform).

> I don't think it is more invasive than using platform data. I did the same
> recently for jz4740 qi-lb60[1] and the changes in the patch are fairly
> trivial. The non-descriptor API is deprecated, so this even if this patch is
> applied as is sooner or later somebody will mechanically convert it to the
> descriptor API.

> [1] https://git.kernel.org/cgit/linux/kernel/git/torvalds/linux.git/commit?id=218e18a3728507ee82ed2eb10c789671a00e34bd

The translation into the GPIO_LOOKUP() macros isn't sufficiently direct,
with platform data it's just a case of putting the same data in a
different file but with this you need to figure out what the GPIO bank
is called which won't appear in the diff typically.  Someone will
doubtless want to finish up the gpiod_ transition at some point but it's
not yet at the point where it's worth blocking unrelated cleanups for
it.

[-- Attachment #1.2: Digital signature --]
[-- Type: application/pgp-signature, Size: 819 bytes --]

[-- Attachment #2: Type: text/plain, Size: 0 bytes --]