From: "Subhransu S. Prusty" <subhransu.s.prusty@intel.com>
To: Lars-Peter Clausen <lars@metafoo.de>
Cc: vinod.koul@intel.com, alsa-devel@alsa-project.org,
broonie@kernel.org, lgirdwood@gmail.com
Subject: Re: [alsa-devel] [v4 02/12] ASoC: Intel: mrfld: set private data for cpu-dai
Date: Thu, 14 Aug 2014 11:06:41 +0530 [thread overview]
Message-ID: <20140814053637.GA6106@vinod.koul@linux.intel.com> (raw)
In-Reply-To: <53EBC193.9070105@metafoo.de>
On Wed, Aug 13, 2014 at 09:50:43PM +0200, Lars-Peter Clausen wrote:
> [...]
> >+static int sst_media_dai_probe(struct snd_soc_dai *cpu_dai)
> >+{
> >+ struct sst_data *sst = dev_get_drvdata(cpu_dai->dev);
> >+
> >+ snd_soc_dai_set_drvdata(cpu_dai, sst);
>
> snd_soc_dai_set_drvdata does dev_set_drvdata(dai->dev, data)
> internally, so this function does:
>
> dev_set_drvdata(cpu_dai->dev, dev_get_drvdata(cpu_dai->dev));
>
> That's pretty much a noop.
>
Agree. Intention was to use snd_soc_dai_* API. Anyway will remove and use
dev_get_drvdata(dai->dev) directly.
--
_______________________________________________
Alsa-devel mailing list
Alsa-devel@alsa-project.org
http://mailman.alsa-project.org/mailman/listinfo/alsa-devel
next prev parent reply other threads:[~2014-08-14 5:58 UTC|newest]
Thread overview: 46+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-08-04 9:45 [v4 00/12] Add mrfld DSP topology and widgets Subhransu S. Prusty
2014-08-04 9:45 ` [v4 01/12] ASoC: Intel: mfld-pcm: add FE and BE ops Subhransu S. Prusty
2014-08-13 19:35 ` Mark Brown
2014-08-04 9:45 ` [v4 02/12] ASoC: Intel: mrfld: set private data for cpu-dai Subhransu S. Prusty
2014-08-13 19:45 ` Mark Brown
2014-08-18 5:39 ` Subhransu S. Prusty
2014-08-18 5:39 ` [alsa-devel] " Subhransu S. Prusty
2014-08-13 19:50 ` Lars-Peter Clausen
2014-08-14 5:36 ` Subhransu S. Prusty
2014-08-14 5:36 ` Subhransu S. Prusty [this message]
2014-08-14 6:16 ` Lars-Peter Clausen
2014-08-04 9:45 ` [v4 03/12] ASoC: intel: mfld-pcm: don't call trigger ops to DSP for internal streams Subhransu S. Prusty
2014-08-04 9:45 ` [v4 04/12] ASoC: Intel: add mrfld DSP defines Subhransu S. Prusty
2014-08-13 19:47 ` Mark Brown
2014-08-04 9:45 ` [v4 05/12] ASoC: Intel: mrfld: add bytes control for modules Subhransu S. Prusty
2014-08-13 20:00 ` Mark Brown
2014-08-18 5:36 ` Subhransu S. Prusty
2014-08-18 5:36 ` [alsa-devel] " Subhransu S. Prusty
2014-08-18 10:15 ` Subhransu S. Prusty
2014-08-18 14:25 ` Mark Brown
2014-08-18 10:15 ` Subhransu S. Prusty
2014-08-18 14:19 ` Mark Brown
2014-08-04 9:45 ` [v4 06/12] ASoC: Intel: mrfld: add the gain controls Subhransu S. Prusty
2014-08-13 20:03 ` Mark Brown
2014-08-18 5:05 ` [alsa-devel] " Subhransu S. Prusty
2014-08-18 5:05 ` Subhransu S. Prusty
2014-08-04 9:45 ` [v4 07/12] ASoC: Intel: mfld-pcm: add control for powering up/down dsp Subhransu S. Prusty
2014-08-13 20:04 ` Mark Brown
2014-08-04 9:45 ` [v4 08/12] ASoC: Intel: mrfld: add DSP core controls Subhransu S. Prusty
2014-08-04 9:46 ` [v4 09/12] ASoC: Export dapm_kcontrol_get_value Subhransu S. Prusty
2014-08-04 9:46 ` [v4 10/12] ASoC: Intel: mrfld: add the DSP DAPM widgets Subhransu S. Prusty
2014-08-13 20:14 ` Mark Brown
2014-08-14 10:21 ` Subhransu S. Prusty
2014-08-14 10:21 ` [alsa-devel] " Subhransu S. Prusty
2014-08-14 13:07 ` Mark Brown
2014-08-18 4:28 ` [alsa-devel] " Subhransu S. Prusty
2014-08-18 13:56 ` Mark Brown
2014-08-19 4:27 ` Subhransu S. Prusty
2014-08-19 4:27 ` [alsa-devel] " Subhransu S. Prusty
2014-08-19 16:03 ` Mark Brown
2014-08-18 4:28 ` Subhransu S. Prusty
2014-08-04 9:46 ` [v4 11/12] ASoC: Intel: mfld-pcm: add the fe & be dai ops Subhransu S. Prusty
2014-08-13 20:16 ` Mark Brown
2014-08-18 4:51 ` [alsa-devel] " Subhransu S. Prusty
2014-08-18 4:51 ` Subhransu S. Prusty
2014-08-04 9:46 ` [v4 12/12] ASoC: Intel: mrfld: add the DSP mixers Subhransu S. Prusty
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140814053637.GA6106@vinod.koul@linux.intel.com \
--to=subhransu.s.prusty@intel.com \
--cc=alsa-devel@alsa-project.org \
--cc=broonie@kernel.org \
--cc=lars@metafoo.de \
--cc=lgirdwood@gmail.com \
--cc=vinod.koul@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).