From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga01.intel.com (mga01.intel.com [192.55.52.88]) by alsa0.perex.cz (Postfix) with ESMTP id BFC2B26547A for ; Mon, 18 Aug 2014 08:01:42 +0200 (CEST) Date: Mon, 18 Aug 2014 11:09:23 +0530 From: "Subhransu S. Prusty" Message-ID: <20140818053923.GE14041@vinod.koul@linux.intel.com> References: <1407145563-1303-1-git-send-email-subhransu.s.prusty@intel.com> <1407145563-1303-3-git-send-email-subhransu.s.prusty@intel.com> <20140813194531.GM17528@sirena.org.uk> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20140813194531.GM17528@sirena.org.uk> Subject: Re: [alsa-devel] [v4 02/12] ASoC: Intel: mrfld: set private data for cpu-dai List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: alsa-devel-bounces@alsa-project.org Sender: alsa-devel-bounces@alsa-project.org To: Mark Brown Cc: vinod.koul@intel.com, alsa-devel@alsa-project.org, Lars-Peter Clausen , lgirdwood@gmail.com List-ID: On Wed, Aug 13, 2014 at 08:45:31PM +0100, Mark Brown wrote: > On Mon, Aug 04, 2014 at 03:15:53PM +0530, Subhransu S. Prusty wrote: > > > We set the driver private data for media dai so that we can use in media > > operations > > This is another one where making the changelog clearer - as far as I can > tell what this is actually doing is moving the existing private data > from being per platform to being per DAI. That actually seems OK and I > would've applied this but it looks like it depends on patch 1. > Will take care. > This lack of clarity is a frequent issue with both of these DSP > serieses, it's really slowing down review since they're quite big and > hard to read. > > > +static int sst_media_dai_probe(struct snd_soc_dai *cpu_dai) > > +{ > > + struct sst_data *sst = dev_get_drvdata(cpu_dai->dev); > > + > > + snd_soc_dai_set_drvdata(cpu_dai, sst); > > + return 0; > > +} > > static struct snd_soc_dai_driver sst_platform_dai[] = { > > Missing blank line here - this is a frequent issue with this code. -- _______________________________________________ Alsa-devel mailing list Alsa-devel@alsa-project.org http://mailman.alsa-project.org/mailman/listinfo/alsa-devel