* [PATCH] ASoC: simple-card: Fix the compile warning.
@ 2014-08-18 7:00 Xiubo Li
2014-08-18 16:42 ` Mark Brown
0 siblings, 1 reply; 2+ messages in thread
From: Xiubo Li @ 2014-08-18 7:00 UTC (permalink / raw)
To: broonie, perex, tiwai, moinejf, kuninori.morimoto.gx, jsarha,
alsa-devel
Cc: Xiubo Li
sound/soc/generic/simple-card.c: In function simple_card_dai_link_of:
sound/soc/generic/simple-card.c:198:10: warning: passing argument 3 of
asoc_simple_card_sub_parse_of from incompatible pointer type [enabled by default]
&dai_link->cpu_dai_name);
^
sound/soc/generic/simple-card.c:112:1: note: expected const struct device_node **
but argument is of type struct device_node **
asoc_simple_card_sub_parse_of(struct device_node *np,
^
sound/soc/generic/simple-card.c:229:10: warning: passing argument 3 of
asoc_simple_card_sub_parse_of from incompatible pointer type [enabled by default]
&dai_link->codec_dai_name);
^
sound/soc/generic/simple-card.c:112:1: note: expected const struct device_node **
but argument is of type struct device_node **
asoc_simple_card_sub_parse_of(struct device_node *np,
^
Since the asoc_simple_card_sub_parse_of() is used in simple-card module only,
and the third argument is just used to get the node ponters address, so there is
no need it must to be 'const' type.
Signed-off-by: Xiubo Li <Li.Xiubo@freescale.com>
---
sound/soc/generic/simple-card.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/sound/soc/generic/simple-card.c b/sound/soc/generic/simple-card.c
index 159e517f..21b0ea2 100644
--- a/sound/soc/generic/simple-card.c
+++ b/sound/soc/generic/simple-card.c
@@ -111,7 +111,7 @@ static int asoc_simple_card_dai_init(struct snd_soc_pcm_runtime *rtd)
static int
asoc_simple_card_sub_parse_of(struct device_node *np,
struct asoc_simple_dai *dai,
- const struct device_node **p_node,
+ struct device_node **p_node,
const char **name)
{
struct device_node *node;
--
1.8.5
^ permalink raw reply related [flat|nested] 2+ messages in thread* Re: [PATCH] ASoC: simple-card: Fix the compile warning.
2014-08-18 7:00 [PATCH] ASoC: simple-card: Fix the compile warning Xiubo Li
@ 2014-08-18 16:42 ` Mark Brown
0 siblings, 0 replies; 2+ messages in thread
From: Mark Brown @ 2014-08-18 16:42 UTC (permalink / raw)
To: Xiubo Li; +Cc: moinejf, alsa-devel, kuninori.morimoto.gx, tiwai, jsarha
[-- Attachment #1.1: Type: text/plain, Size: 221 bytes --]
On Mon, Aug 18, 2014 at 03:00:15PM +0800, Xiubo Li wrote:
> sound/soc/generic/simple-card.c: In function simple_card_dai_link_of:
> sound/soc/generic/simple-card.c:198:10: warning: passing argument 3 of
Applied, thanks.
[-- Attachment #1.2: Digital signature --]
[-- Type: application/pgp-signature, Size: 819 bytes --]
[-- Attachment #2: Type: text/plain, Size: 0 bytes --]
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2014-08-18 16:43 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2014-08-18 7:00 [PATCH] ASoC: simple-card: Fix the compile warning Xiubo Li
2014-08-18 16:42 ` Mark Brown
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).