From: Nicolin Chen <nicoleotsuka@gmail.com>
To: Xiubo Li <Li.Xiubo@freescale.com>
Cc: broonie@kernel.org, timur@tabi.org, lgirdwood@gmail.com,
perex@perex.cz, tiwai@suse.de, alsa-devel@alsa-project.org,
galak@codeaurora.org, mark.rutland@arm.com, robh+dt@kernel.org,
pawel.moll@arm.com, linux-kernel@vger.kernel.org
Subject: Re: [PATCHv3 1/4] ASoC: fsl-asrc: Convert to use regmap framework's endianness method.
Date: Sun, 24 Aug 2014 21:11:01 -0700 [thread overview]
Message-ID: <20140825041100.GA2126@Alpha> (raw)
In-Reply-To: <1408937462-18727-2-git-send-email-Li.Xiubo@freescale.com>
On Mon, Aug 25, 2014 at 11:30:59AM +0800, Xiubo Li wrote:
> Signed-off-by: Xiubo Li <Li.Xiubo@freescale.com>
> ---
> sound/soc/fsl/fsl_asrc.c | 6 +-----
> 1 file changed, 1 insertion(+), 5 deletions(-)
>
> diff --git a/sound/soc/fsl/fsl_asrc.c b/sound/soc/fsl/fsl_asrc.c
> index 8221104..3b14531 100644
> --- a/sound/soc/fsl/fsl_asrc.c
> +++ b/sound/soc/fsl/fsl_asrc.c
> @@ -802,10 +802,6 @@ static int fsl_asrc_probe(struct platform_device *pdev)
>
> asrc_priv->paddr = res->start;
>
> - /* Register regmap and let it prepare core clock */
Oops, I didn't notice this change. This should be needless.
Otherwise, the whole change within sound/soc/fsl by this series looks fine.
Acked-by: Nicolin Chen <nicoleotsuka@gmail.com>
> - if (of_property_read_bool(np, "big-endian"))
> - fsl_asrc_regmap_config.val_format_endian = REGMAP_ENDIAN_BIG;
> -
next prev parent reply other threads:[~2014-08-25 4:11 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-08-25 3:30 [PATCHv3 0/4] ASoC: Convert to use regmap framework's endianness method Xiubo Li
2014-08-25 3:30 ` [PATCHv3 1/4] ASoC: fsl-asrc: " Xiubo Li
2014-08-25 4:11 ` Nicolin Chen [this message]
2014-08-25 3:31 ` [PATCHv3 2/4] ASoC: fsl-esai: " Xiubo Li
2014-08-25 3:31 ` [PATCHv3 3/4] ASoC: fsl-spdif: " Xiubo Li
2014-08-25 3:31 ` [PATCHv3 4/4] ASoC: fsl-sai: " Xiubo Li
2014-08-27 18:19 ` [PATCHv3 0/4] ASoC: " Mark Brown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140825041100.GA2126@Alpha \
--to=nicoleotsuka@gmail.com \
--cc=Li.Xiubo@freescale.com \
--cc=alsa-devel@alsa-project.org \
--cc=broonie@kernel.org \
--cc=galak@codeaurora.org \
--cc=lgirdwood@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mark.rutland@arm.com \
--cc=pawel.moll@arm.com \
--cc=perex@perex.cz \
--cc=robh+dt@kernel.org \
--cc=timur@tabi.org \
--cc=tiwai@suse.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).