From: "Subhransu S. Prusty" <subhransu.s.prusty@intel.com>
To: Mark Brown <broonie@kernel.org>
Cc: vinod.koul@intel.com, alsa-devel@alsa-project.org,
Lars-Peter Clausen <lars@metafoo.de>,
lgirdwood@gmail.com
Subject: Re: [alsa-devel] [v3 08/11] ASoC: Intel: sst: add power management handling
Date: Mon, 1 Sep 2014 17:49:59 +0530 [thread overview]
Message-ID: <20140901121959.GE12898@vinod.koul@linux.intel.com> (raw)
In-Reply-To: <20140827204654.GA17528@sirena.org.uk>
On Wed, Aug 27, 2014 at 09:46:54PM +0100, Mark Brown wrote:
> On Thu, Aug 21, 2014 at 06:20:47PM +0530, Subhransu S. Prusty wrote:
>
> > + /* When fw_clear_cache is set, clear the cached firmware copy */
> > + /* fw_clear_cache is set through debugfs support */
>
> Not in this patch series!
Yes. Will remove.
>
> > + if (atomic_read(&ctx->fw_clear_cache) && ctx->fw_in_mem) {
>
> Why is this an atomic operation? They're a bit of an alarm bell for
> correctness and it'd seem useful if the clear just happened immediately
> anyway.
>
> > + if (ret) {
> > + pr_err("FW download fail %x\n", ret);
> > + ctx->sst_state = SST_RESET;
> > + mutex_unlock(&ctx->sst_lock);
> > + sst_pm_runtime_put(ctx);
>
> This is a runtime_pm_put() in the runtime PM callback? That doesn't
> look right.
Mistakenly added. Not required.
--
_______________________________________________
Alsa-devel mailing list
Alsa-devel@alsa-project.org
http://mailman.alsa-project.org/mailman/listinfo/alsa-devel
next prev parent reply other threads:[~2014-09-01 12:42 UTC|newest]
Thread overview: 37+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-08-21 12:50 [v3 00/11] ASoC: Intel: sst - add the merrifield IPC driver Subhransu S. Prusty
2014-08-21 12:50 ` [v3 01/11] ASoC: Intel: mrfld - add the dsp sst driver Subhransu S. Prusty
2014-08-27 19:40 ` Mark Brown
2014-09-01 10:37 ` Subhransu S. Prusty
2014-09-01 10:37 ` [alsa-devel] " Subhransu S. Prusty
2014-09-01 11:15 ` Mark Brown
2014-08-21 12:50 ` [v3 02/11] ASoC: Intel: mrfld - Add DSP load and management Subhransu S. Prusty
2014-08-27 20:17 ` Mark Brown
2014-09-01 11:45 ` [alsa-devel] " Subhransu S. Prusty
2014-09-01 11:45 ` Subhransu S. Prusty
2014-08-21 12:50 ` [v3 03/11] ASoC: Intel: sst - add pcm ops handling Subhransu S. Prusty
2014-08-27 20:29 ` Mark Brown
2014-08-21 12:50 ` [v3 04/11] ASoC: Intel: sst: Add IPC handling Subhransu S. Prusty
2014-08-27 20:37 ` Mark Brown
2014-09-01 12:17 ` Subhransu S. Prusty
2014-09-01 12:17 ` [alsa-devel] " Subhransu S. Prusty
2014-09-01 12:51 ` Mark Brown
2014-09-01 13:57 ` [alsa-devel] " Subhransu S. Prusty
2014-09-01 14:41 ` Mark Brown
2014-09-02 5:22 ` Vinod Koul
2014-09-03 18:39 ` Mark Brown
2014-09-01 13:57 ` Subhransu S. Prusty
2014-08-21 12:50 ` [v3 05/11] ASoC: Intel: sst: add stream operations Subhransu S. Prusty
2014-08-27 20:41 ` Mark Brown
2014-09-01 12:18 ` Subhransu S. Prusty
2014-09-01 12:18 ` [alsa-devel] " Subhransu S. Prusty
2014-08-21 12:50 ` [v3 06/11] ASoC: Intel: sst: Add some helper functions Subhransu S. Prusty
2014-08-21 12:50 ` [v3 07/11] ASoC: Intel: sst: Add makefile and kconfig changes Subhransu S. Prusty
2014-08-21 12:50 ` [v3 08/11] ASoC: Intel: sst: add power management handling Subhransu S. Prusty
2014-08-27 20:46 ` Mark Brown
2014-09-01 12:19 ` Subhransu S. Prusty [this message]
2014-09-01 12:19 ` Subhransu S. Prusty
2014-08-21 12:50 ` [v3 09/11] ASoC: Intel: sst: load firmware using async callback Subhransu S. Prusty
2014-08-21 12:50 ` [v3 10/11] ASoC: mfld-compress: Use dedicated function instead of ioctl Subhransu S. Prusty
2014-08-27 20:51 ` Mark Brown
2014-08-21 12:50 ` [v3 11/11] ASoC: Intel: sst - add compressed ops handling Subhransu S. Prusty
2014-08-27 20:52 ` Mark Brown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140901121959.GE12898@vinod.koul@linux.intel.com \
--to=subhransu.s.prusty@intel.com \
--cc=alsa-devel@alsa-project.org \
--cc=broonie@kernel.org \
--cc=lars@metafoo.de \
--cc=lgirdwood@gmail.com \
--cc=vinod.koul@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).