From: Charles Keepax <ckeepax@opensource.wolfsonmicro.com>
To: Lars-Peter Clausen <lars@metafoo.de>
Cc: alsa-devel@alsa-project.org, patches@opensource.wolfsonmicro.com,
Liam Girdwood <lgirdwood@gmail.com>,
Peter Ujfalusi <peter.ujfalusi@ti.com>,
Vishwas A Deshpande <vishwas.a.deshpande@ti.com>,
Mark Brown <broonie@kernel.org>,
M R Swami Reddy <mr.swami.reddy@ti.com>
Subject: Re: [PATCH 4/5] ASoC: wm8804: Remove unnecessary suspend/resume bias level changes
Date: Wed, 3 Sep 2014 09:21:54 +0100 [thread overview]
Message-ID: <20140903082154.GL12043@opensource.wolfsonmicro.com> (raw)
In-Reply-To: <1409689234-14774-5-git-send-email-lars@metafoo.de>
On Tue, Sep 02, 2014 at 10:20:33PM +0200, Lars-Peter Clausen wrote:
> The ASoC core will only call the suspend/resume callbacks when the device's
> DAPM context is idle. Since this driver sets idle_bias_off to true this
> means that the device is already in SND_SOC_BIAS_OFF when the suspend
> callback is called, so there is no need to manually set this state again.
> There is also no need to go to SND_SOC_BIAS_STANDBY in the resume callback
> since the core will go right back to SND_SOC_BIAS_OFF.
>
> Signed-off-by: Lars-Peter Clausen <lars@metafoo.de>
> ---
Acked-by: Charles Keepax <ckeepax@opensource.wolfsonmicro.com>
Thanks,
Charles
next prev parent reply other threads:[~2014-09-03 8:21 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-09-02 20:20 [PATCH 0/5] ASoC: Remove unnecessary suspend/resume bias level changes Lars-Peter Clausen
2014-09-02 20:20 ` [PATCH 1/5] ASoC: adau1373: " Lars-Peter Clausen
2014-09-02 20:20 ` [PATCH 2/5] ASoC: lm49453: " Lars-Peter Clausen
2014-09-02 20:20 ` [PATCH 3/5] ASoC: tlv320aic3x: " Lars-Peter Clausen
2014-09-02 20:20 ` [PATCH 4/5] ASoC: wm8804: " Lars-Peter Clausen
2014-09-03 8:21 ` Charles Keepax [this message]
2014-09-02 20:20 ` [PATCH 5/5] ASoC: wm8995: " Lars-Peter Clausen
2014-09-03 8:22 ` Charles Keepax
2014-09-03 18:26 ` [PATCH 0/5] ASoC: " Mark Brown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140903082154.GL12043@opensource.wolfsonmicro.com \
--to=ckeepax@opensource.wolfsonmicro.com \
--cc=alsa-devel@alsa-project.org \
--cc=broonie@kernel.org \
--cc=lars@metafoo.de \
--cc=lgirdwood@gmail.com \
--cc=mr.swami.reddy@ti.com \
--cc=patches@opensource.wolfsonmicro.com \
--cc=peter.ujfalusi@ti.com \
--cc=vishwas.a.deshpande@ti.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).