From mboxrd@z Thu Jan 1 00:00:00 1970 From: Charles Keepax Subject: Re: [PATCH 4/5] ASoC: wm8804: Remove unnecessary suspend/resume bias level changes Date: Wed, 3 Sep 2014 09:21:54 +0100 Message-ID: <20140903082154.GL12043@opensource.wolfsonmicro.com> References: <1409689234-14774-1-git-send-email-lars@metafoo.de> <1409689234-14774-5-git-send-email-lars@metafoo.de> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: Received: from opensource.wolfsonmicro.com (opensource.wolfsonmicro.com [80.75.67.52]) by alsa0.perex.cz (Postfix) with ESMTP id CA26F26563A for ; Wed, 3 Sep 2014 10:21:54 +0200 (CEST) Content-Disposition: inline In-Reply-To: <1409689234-14774-5-git-send-email-lars@metafoo.de> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: alsa-devel-bounces@alsa-project.org Sender: alsa-devel-bounces@alsa-project.org To: Lars-Peter Clausen Cc: alsa-devel@alsa-project.org, patches@opensource.wolfsonmicro.com, Liam Girdwood , Peter Ujfalusi , Vishwas A Deshpande , Mark Brown , M R Swami Reddy List-Id: alsa-devel@alsa-project.org On Tue, Sep 02, 2014 at 10:20:33PM +0200, Lars-Peter Clausen wrote: > The ASoC core will only call the suspend/resume callbacks when the device's > DAPM context is idle. Since this driver sets idle_bias_off to true this > means that the device is already in SND_SOC_BIAS_OFF when the suspend > callback is called, so there is no need to manually set this state again. > There is also no need to go to SND_SOC_BIAS_STANDBY in the resume callback > since the core will go right back to SND_SOC_BIAS_OFF. > > Signed-off-by: Lars-Peter Clausen > --- Acked-by: Charles Keepax Thanks, Charles