Alsa-Devel Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: Jean-Francois Moine <moinejf@free.fr>
To: Benoit Cousson <bcousson@baylibre.com>
Cc: Xiubo Li <Li.Xiubo@freescale.com>,
	alsa-devel@alsa-project.org, Mark Brown <broonie@kernel.org>,
	Kuninori Morimoto <kuninori.morimoto.gx@gmail.com>,
	Jyri Sarha <jsarha@ti.com>
Subject: Re: [PATCH] ASoC:simple-card: Add multi-CODEC support
Date: Wed, 10 Sep 2014 18:06:39 +0200	[thread overview]
Message-ID: <20140910180639.6a92a33c@armhf> (raw)
In-Reply-To: <5410394A.1030508@baylibre.com>

On Wed, 10 Sep 2014 13:43:06 +0200
Benoit Cousson <bcousson@baylibre.com> wrote:

> > +		codec@0 {
> > +			sound-dai = <&hdmi 0>;
> > +		};
> > +		codec@1 {
> > +			sound-dai = <&spdif_codec>;
> >   		};  
> 
> I don't have strong opinion on that, but in my case, I was considering 
> using a simple list instead of several nodes.
> I don't like having to add fake address just to ensure uniqueness.
> 
> Something like that:
> 
>   sound-dais = <&spdif_codec 1>, <&hdmi 0>;

You are right, this would be simpler (I did not see that there could be
phandle's with different cell sizes in a list).

> That being said, it will require changing the name with a plural form, 
> and ensuring we have the same number of parameters for each codec.

But I don't think that changing the name could be useful: the treatment
is exactly the same and, as a result, all CODEC DAIs go to the DAI
list of the DAI link.

-- 
Ken ar c'hentañ	|	      ** Breizh ha Linux atav! **
Jef		|		http://moinejf.free.fr/
_______________________________________________
Alsa-devel mailing list
Alsa-devel@alsa-project.org
http://mailman.alsa-project.org/mailman/listinfo/alsa-devel

  reply	other threads:[~2014-09-10 16:04 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <54103671.c36bb40a.2743.ffff969aSMTPIN_ADDED_MISSING@mx.google.com>
2014-09-10 11:43 ` [PATCH] ASoC:simple-card: Add multi-CODEC support Benoit Cousson
2014-09-10 16:06   ` Jean-Francois Moine [this message]
2014-09-10 16:27     ` Benoit Cousson
2014-09-10 17:25       ` Jean-Francois Moine
2014-09-10 11:28 Jean-Francois Moine

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20140910180639.6a92a33c@armhf \
    --to=moinejf@free.fr \
    --cc=Li.Xiubo@freescale.com \
    --cc=alsa-devel@alsa-project.org \
    --cc=bcousson@baylibre.com \
    --cc=broonie@kernel.org \
    --cc=jsarha@ti.com \
    --cc=kuninori.morimoto.gx@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox