From: Mark Brown <broonie@kernel.org>
To: Nikesh Oswal <nikesh@opensource.wolfsonmicro.com>
Cc: lgirdwood@gmail.com, perex@perex.cz, tiwai@suse.de,
alsa-devel@alsa-project.org, linux-kernel@vger.kernel.org,
patches@opensource.wolfsonmicro.com
Subject: Re: [PATCH v5] ASoC: dapm: add code to configure dai link parameters
Date: Thu, 11 Sep 2014 19:37:22 +0100 [thread overview]
Message-ID: <20140911183722.GR4015@sirena.org.uk> (raw)
In-Reply-To: <1410432139-15089-1-git-send-email-nikesh@opensource.wolfsonmicro.com>
[-- Attachment #1: Type: text/plain, Size: 715 bytes --]
On Thu, Sep 11, 2014 at 11:42:18AM +0100, Nikesh Oswal wrote:
> + /* add kcontrol */
> + for (i = 0; i < w->num_kcontrols; i++) {
> + kcontrol = snd_soc_cnew(&w->kcontrol_news[i], w,
> + w->name, NULL);
> + ret = snd_ctl_add(card, kcontrol);
*sigh* As I wrote before in response to exactly the same code:
| Throughout this you've got coding style problems, you're not indenting
| the continuations of multi-line statements. Please try to follow the
| kernel coding style, if your code is visibly different to the rest of
| the codebase that's not good.
Please pay attention to review comments, just completely ignoring them
isn't good. If you don't feel some change should be made then reply and
discuss.
[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 473 bytes --]
prev parent reply other threads:[~2014-09-11 18:37 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-09-11 10:42 [PATCH v5] ASoC: dapm: add code to configure dai link parameters Nikesh Oswal
2014-09-11 18:37 ` Mark Brown [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140911183722.GR4015@sirena.org.uk \
--to=broonie@kernel.org \
--cc=alsa-devel@alsa-project.org \
--cc=lgirdwood@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=nikesh@opensource.wolfsonmicro.com \
--cc=patches@opensource.wolfsonmicro.com \
--cc=perex@perex.cz \
--cc=tiwai@suse.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).