Re: [PATCH] ASoC: fsl_ssi: Remove unneeded 'i2s-slave' property

[Nicolin Chen <nicoleotsuka@gmail.com>]

On Thu, Sep 18, 2014 at 06:46:42PM +0000, Fabio.Estevam@freescale.com wrote:
> On 09/18/2014 01:32 PM, Nicolin Chen wrote:
> > On Thu, Sep 18, 2014 at 03:11:17PM -0300, Fabio Estevam wrote:
> >> There is no need to use 'i2s-slave' property, since master/slave configuration
> >> are passed via machine layer.
> >>
> >> This change does not break existing users because they do check for slave
> >> mode inside sound/soc/fsl/mpc8610_hpcd.c/p1022_ds.c and p1022_rdk.c
> >
> > Besides this change, I'm wondering if we can take a further step to drop
> > this entire property from Device Tree binding document as newer platforms
> > may no long need this property in their DT bindings.
> 
> I think the property is necessary if anyone takes a P1022 or MPC8610 and
> uses it in a platform that doesn't support i2s-slave.  But currently,
> the code doesn't support anything else.  So technically, we could remove
> it, and if anyone does want to support another configuration, he will
> have to add that support the "new" way.

Thank you for the comments. Then we may use compatible check for
P1022 and MPC8610 to limit their DAI formats.

For the property, do you agree to modify it like this:

- fsl,mode:         The operating mode for the AC97 interface only.
                    "ac97-slave" - AC97 mode, SSI is clock slave
                    "ac97-master" - AC97 mode, SSI is clock master
                    (There's no need for other DAI format like I2S
		    mode to engage this property.)

And how about this patch? I'm personally okay with this change.
We may also send an extra patch to refine the document after the
agreement's done.

Thanks
Nicolin