From: Nicolin Chen <nicoleotsuka@gmail.com>
To: Timur Tabi <timur@tabi.org>
Cc: "Fabio.Estevam@freescale.com" <Fabio.Estevam@freescale.com>,
"Li.Xiubo@freescale.com" <Li.Xiubo@freescale.com>,
"alsa-devel@alsa-project.org" <alsa-devel@alsa-project.org>,
"broonie@kernel.org" <broonie@kernel.org>
Subject: Re: [PATCH] ASoC: fsl_ssi: Remove unneeded 'i2s-slave' property
Date: Thu, 18 Sep 2014 21:17:49 -0700 [thread overview]
Message-ID: <20140919041749.GA5840@Asurada> (raw)
In-Reply-To: <541B78EC.5050702@tabi.org>
On Thu, Sep 18, 2014 at 07:29:32PM -0500, Timur Tabi wrote:
> >For the property, do you agree to modify it like this:
> >
> >- fsl,mode: The operating mode for the AC97 interface only.
> > "ac97-slave" - AC97 mode, SSI is clock slave
> > "ac97-master" - AC97 mode, SSI is clock master
> > (There's no need for other DAI format like I2S
> > mode to engage this property.)
> You can't just redefine a property, because that breaks backwards
> compatibility with older device trees or older kernels.
Sorry, I'm not sure what's the problem here. It just drops i2s stuff
and leave AC97 part as we discussed. Why would old DTs be broken?
Is that possible for you to give me an example to understand the
point?
Thank you
Nicolin
next prev parent reply other threads:[~2014-09-19 4:17 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <1411063877-1552-1-git-send-email-fabio.estevam@freescale.com>
[not found] ` <20140918183251.GE6432@Asurada>
[not found] ` <541B2678.8000401@tabi.org>
2014-09-18 18:46 ` [PATCH] ASoC: fsl_ssi: Remove unneeded 'i2s-slave' property Fabio.Estevam
2014-09-18 19:43 ` Nicolin Chen
2014-09-19 0:29 ` Timur Tabi
2014-09-19 4:17 ` Nicolin Chen [this message]
2014-09-19 12:51 ` Timur Tabi
2014-09-19 17:24 ` Nicolin Chen
2014-09-19 23:49 ` Timur Tabi
2014-09-20 18:07 ` Nicolin Chen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140919041749.GA5840@Asurada \
--to=nicoleotsuka@gmail.com \
--cc=Fabio.Estevam@freescale.com \
--cc=Li.Xiubo@freescale.com \
--cc=alsa-devel@alsa-project.org \
--cc=broonie@kernel.org \
--cc=timur@tabi.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).