From mboxrd@z Thu Jan 1 00:00:00 1970 From: Nicolin Chen Subject: Re: =?iso-8859-1?q?No_sound_captured_with_SGTL5000_on_i?= =?iso-8859-1?q?=2EMX6_in_I=B2S_master_mode?= Date: Fri, 19 Sep 2014 00:52:28 -0700 Message-ID: <20140919075228.GA4376@Asurada> References: <20140918170524.GA6080@Asurada> <20140918174935.GB6432@Asurada> <20140918180742.GC6432@Asurada> <20140918183910.GF6432@Asurada> <20140918235045.GA4148@Asurada> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: Received: from mail-pa0-f47.google.com (mail-pa0-f47.google.com [209.85.220.47]) by alsa0.perex.cz (Postfix) with ESMTP id 711AA261683 for ; Fri, 19 Sep 2014 09:52:37 +0200 (CEST) Received: by mail-pa0-f47.google.com with SMTP id kx10so824652pab.34 for ; Fri, 19 Sep 2014 00:52:36 -0700 (PDT) Content-Disposition: inline In-Reply-To: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: alsa-devel-bounces@alsa-project.org Sender: alsa-devel-bounces@alsa-project.org To: Jean-Michel Hautbois Cc: Shengjiu Wang , Lars-Peter Clausen , "alsa-devel@alsa-project.org" , Markus Pargmann , Michael Trimarchi , Fabio Estevam , Shawn Guo List-Id: alsa-devel@alsa-project.org On Fri, Sep 19, 2014 at 09:42:22AM +0200, Jean-Michel Hautbois wrote: > Hi, > > 2014-09-19 1:50 GMT+02:00 Nicolin Chen : > > On Thu, Sep 18, 2014 at 08:35:31PM -0300, Fabio Estevam wrote: > >> On Thu, Sep 18, 2014 at 3:39 PM, Nicolin Chen wrote: > >> > >> > It actually is merged into broonie/for-next and even linux-next I think. > >> > I'll later send a patch to Shawn's tree for imx_v6_v7_defconfig changes > >> > after next merge window's done. > >> > >> Ok, I see it now, but master/slave configuration is still hardcoded there: > >> > >> } else if (of_device_is_compatible(np, "fsl,imx-audio-sgtl5000")) { > >> priv->codec_priv.mclk_id = SGTL5000_SYSCLK; > >> priv->dai_fmt |= SND_SOC_DAIFMT_CBM_CFM; > > > > It's just a combinational driver and also made to be compatible with > > old DTs. Unless we refine the DT binding like simple-card, this hard- > > code is inevitable. As long as this dai_fmt has been defined, at least > > AUDMUX part will be automatically configured. > > > > I made this driver was initially to support ASRC for imx-cs42888. But > > merging the code from imx-sgtl5000 and imx-wm8962 allows us to omit > > a branch of duplicated code. And that's it :) > > > > Well, I may have missed something, I don't have fsl-asoc-card in my > linux tree (vanilla). Where can I find it ? I can test a SGTL5000 > master mode on i.MX6Q. git://git.kernel.org/pub/scm/linux/kernel/git/broonie/sound.git for-next branch. Nicolin