From: Dan Carpenter <dan.carpenter@oracle.com>
To: anatol.pomozov@gmail.com
Cc: alsa-devel@alsa-project.org
Subject: Re: ASoC: ssm4567: Add driver for Analog Devices SSM4567 amplifier
Date: Wed, 1 Oct 2014 20:02:57 +0300 [thread overview]
Message-ID: <20141001170257.GB11786@mwanda> (raw)
Hello Anatol Pomozov,
The patch 1ee44ce03011: "ASoC: ssm4567: Add driver for Analog Devices
SSM4567 amplifier" from Sep 26, 2014, leads to the following static
checker warning:
sound/soc/codecs/ssm4567.c:176 ssm4567_hw_params()
warn: we tested 'rate <= 96000' before and it was 'false'
sound/soc/codecs/ssm4567.c
160 static int ssm4567_hw_params(struct snd_pcm_substream *substream,
161 struct snd_pcm_hw_params *params, struct snd_soc_dai *dai)
162 {
163 struct snd_soc_codec *codec = dai->codec;
164 struct ssm4567 *ssm4567 = snd_soc_codec_get_drvdata(codec);
165 unsigned int rate = params_rate(params);
166 unsigned int dacfs;
167
168 if (rate >= 8000 && rate <= 12000)
169 dacfs = SSM4567_DAC_FS_8000_12000;
170 else if (rate >= 16000 && rate <= 24000)
171 dacfs = SSM4567_DAC_FS_16000_24000;
172 else if (rate >= 32000 && rate <= 48000)
173 dacfs = SSM4567_DAC_FS_32000_48000;
174 else if (rate >= 64000 && rate <= 96000)
175 dacfs = SSM4567_DAC_FS_64000_96000;
176 else if (rate >= 64000 && rate <= 96000)
177 dacfs = SSM4567_DAC_FS_64000_96000;
These two lines are a cut and paste error. The intent is not clear.
178 else if (rate >= 128000 && rate <= 192000)
179 dacfs = SSM4567_DAC_FS_128000_192000;
180 else
181 return -EINVAL;
182
183 return regmap_update_bits(ssm4567->regmap, SSM4567_REG_DAC_CTRL,
184 SSM4567_DAC_FS_MASK, dacfs);
185 }
regards,
dan carpenter
next reply other threads:[~2014-10-01 17:03 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-10-01 17:02 Dan Carpenter [this message]
2014-10-01 17:12 ` ASoC: ssm4567: Add driver for Analog Devices SSM4567 amplifier Anatol Pomozov
2014-10-01 17:44 ` Dan Carpenter
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20141001170257.GB11786@mwanda \
--to=dan.carpenter@oracle.com \
--cc=alsa-devel@alsa-project.org \
--cc=anatol.pomozov@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox