Re: [PATCH v7 5/7] ASoC: Intel: mrfld: add the DSP DAPM widgets

[Vinod Koul <vinod.koul@intel.com>]

[-- Attachment #1.1: Type: text/plain, Size: 1335 bytes --]

On Mon, Oct 06, 2014 at 08:10:10AM +0530, Vinod Koul wrote:
> On Thu, Oct 02, 2014 at 07:12:28PM +0100, Mark Brown wrote:
> > On Fri, Sep 19, 2014 at 04:46:06PM +0530, Subhransu S. Prusty wrote:
> > 
> > > +#define SST_MMX_DECLARE_MIX_CONTROLS(kctl_name)			\
> > > +	static const struct snd_kcontrol_new kctl_name[] = {			\
> > > +		SOC_DAPM_SINGLE("media0_in", SND_SOC_NOPM, SST_IP_MEDIA0, 1, 0),	\
> > > +		SOC_DAPM_SINGLE("media1_in", SND_SOC_NOPM, SST_IP_MEDIA1, 1, 0),	\
> > > +		SOC_DAPM_SINGLE("media2_in", SND_SOC_NOPM, SST_IP_MEDIA2, 1, 0),	\
> > > +		SOC_DAPM_SINGLE("media3_in", SND_SOC_NOPM, SST_IP_MEDIA3, 1, 0),	\
> > > +	}
> > 
> > These should be Switch controls?
> Yup I will fix this one.
> 
> > 
> > > +	snd_soc_dapm_new_controls(dapm, sst_dapm_widgets,
> > > +			ARRAY_SIZE(sst_dapm_widgets));
> > > +	snd_soc_dapm_add_routes(dapm, intercon,
> > > +			ARRAY_SIZE(intercon));
> > > +	snd_soc_dapm_new_widgets(dapm->card);
> > 
> > We should be able to do this from the component but we can't yet...
> We can convert once ready :)
> 
> I still have lots of stuff to do once this series is in. We also need to
> enable dynamic firmware here once liam upstreams basic support :)

Wanted to check if you have any comments on last two patches, before I
send updated series :)

-- 
~Vinod

[-- Attachment #1.2: Digital signature --]
[-- Type: application/pgp-signature, Size: 836 bytes --]

[-- Attachment #2: Type: text/plain, Size: 0 bytes --]