Alsa-Devel Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: Mark Brown <broonie@kernel.org>
To: Geert Uytterhoeven <geert@linux-m68k.org>
Cc: Dylan Reid <dgreid@chromium.org>,
	ALSA Development Mailing List <alsa-devel@alsa-project.org>,
	jay.xu@rock-chips.com,
	"devicetree@vger.kernel.org" <devicetree@vger.kernel.org>,
	sonnyrao@chromium.org,
	Kuninori Morimoto <kuninori.morimoto.gx@gmail.com>,
	Linux-sh list <linux-sh@vger.kernel.org>
Subject: Re: [PATCH] ASoC: simple-card: Add mic and hp detect gpios.
Date: Tue, 7 Oct 2014 13:38:56 +0100	[thread overview]
Message-ID: <20141007123856.GF4609@sirena.org.uk> (raw)
In-Reply-To: <CAMuHMdWh=sXAD59T1T=gvROX+fbF6=gFo6C0nkJdfnCrdNrwYg@mail.gmail.com>

[-- Attachment #1: Type: text/plain, Size: 696 bytes --]

On Tue, Oct 07, 2014 at 02:32:57PM +0200, Geert Uytterhoeven wrote:

> Hence on r8a7740/armadillo-legacy, which uses platform devices instead of DT:

>     sh-mobile-hdmi sh-mobile-hdmi: SH Mobile HDMI Audio Codec
>     sh-mobile-hdmi sh-mobile-hdmi: ASoC: DAPM unknown pin Headphones
>     sh-mobile-hdmi sh-mobile-hdmi: ASoC: DAPM unknown pin Mic Jack

> After that the kernel log is spammed ca. 7 times per second with:

>     sh-mobile-hdmi sh-mobile-hdmi: ASoC: DAPM unknown pin Headphones

> Reverting commit 3fe240326cc395c66 ("ASoC: simple-card: Add mic and
> hp detect gpios.") fixes this.

The fix here is to not allow 0 as a GPIO in the core code (which
should've been there already).

[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 473 bytes --]

  reply	other threads:[~2014-10-07 12:38 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-10-01 21:25 [PATCH] ASoC: simple-card: Add mic and hp detect gpios Dylan Reid
     [not found] ` <1412198720-2326-1-git-send-email-dgreid-F7+t8E8rja9g9hUCZPvPmw@public.gmane.org>
2014-10-02 15:53   ` Mark Brown
2014-10-07 12:32     ` Geert Uytterhoeven
2014-10-07 12:38       ` Mark Brown [this message]
2014-10-07 13:10         ` Geert Uytterhoeven
2014-10-07 16:36           ` Mark Brown
2014-10-08  7:05             ` Alexandre Courbot
2014-10-08  8:50               ` Linus Walleij
2014-10-08 11:40                 ` Mark Brown
2014-10-02 16:25   ` [alsa-devel] " Lars-Peter Clausen
     [not found]     ` <542D7C73.20801-Qo5EllUWu/uELgA04lAiVw@public.gmane.org>
2014-10-02 16:57       ` Dylan Reid
2014-10-22  6:44   ` Jianqun

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20141007123856.GF4609@sirena.org.uk \
    --to=broonie@kernel.org \
    --cc=alsa-devel@alsa-project.org \
    --cc=devicetree@vger.kernel.org \
    --cc=dgreid@chromium.org \
    --cc=geert@linux-m68k.org \
    --cc=jay.xu@rock-chips.com \
    --cc=kuninori.morimoto.gx@gmail.com \
    --cc=linux-sh@vger.kernel.org \
    --cc=sonnyrao@chromium.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox