From: Mark Brown <broonie@kernel.org>
To: Takashi Iwai <tiwai@suse.de>
Cc: Fabio Estevam <fabio.estevam@freescale.com>,
alsa-devel@alsa-project.org, Timur Tabi <timur@tabi.org>,
Liam Girdwood <lgirdwood@gmail.com>,
Sachin Kamat <sachin.kamat@samsung.com>,
Nicolin Chen <nicoleotsuka@gmail.com>,
Xiubo Li <Li.Xiubo@freescale.com>, Sean Cross <xobs@kosagi.com>
Subject: Re: [GIT PULL] ASoC updates for v3.18
Date: Tue, 7 Oct 2014 18:14:36 +0100 [thread overview]
Message-ID: <20141007171436.GA23707@sirena.org.uk> (raw)
In-Reply-To: <s5htx3hxtjy.wl-tiwai@suse.de>
[-- Attachment #1.1: Type: text/plain, Size: 1117 bytes --]
On Mon, Oct 06, 2014 at 02:37:53PM +0200, Takashi Iwai wrote:
> Mark Brown wrote:
> However, this resulted in a few new build warnings, and some of them
> look correctly reported.
> * sound/soc/codecs/mc13783.c:787:13: warning: 'np' may be used uninitialized in this function [-Wuninitialized]
> The call of_node_put(np) is done unconditionally even for non-NULL
> pdata where np isn't initialized. This may lead to a real crash.
> * sound/soc/fsl/eukrea-tlv320.c:221:14: warning: 'ssi_np' may be used uninitialized in this function [-Wuninitialized]
> A similar bug: of_node_put(ssi_np) is reached even before ssi_np is
> initialized.
> * sound/soc/fsl/imx-es8328.c:196:13: warning: 'codec_np' may be used uninitialized in this function [-Wuninitialized]
> * sound/soc/fsl/imx-es8328.c:195:13: warning: 'ssi_np' may be used uninitialized in this function [-Wuninitialized]
> Ditto.
> Relevant people put in Cc. I hope I'll get a new pull request soon
> later :)
You missed CCing the Freescale guys and Timur so you're missing most of
the relevant people here; adding them now.
[-- Attachment #1.2: Digital signature --]
[-- Type: application/pgp-signature, Size: 473 bytes --]
[-- Attachment #2: Type: text/plain, Size: 0 bytes --]
next prev parent reply other threads:[~2014-10-07 17:14 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-10-06 11:51 [GIT PULL] ASoC updates for v3.18 Mark Brown
2014-10-06 12:37 ` Takashi Iwai
2014-10-06 13:07 ` Mark Brown
2014-10-06 13:12 ` Takashi Iwai
2014-10-06 13:31 ` Mark Brown
2014-10-06 13:36 ` Takashi Iwai
2014-10-07 17:14 ` Mark Brown [this message]
2014-10-07 17:53 ` Fabio Estevam
2014-10-07 18:07 ` Takashi Iwai
2014-10-07 18:15 ` Takashi Iwai
2014-10-07 18:01 ` Nicolin Chen
2014-10-07 18:08 ` Takashi Iwai
2014-10-07 18:12 ` Nicolin Chen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20141007171436.GA23707@sirena.org.uk \
--to=broonie@kernel.org \
--cc=Li.Xiubo@freescale.com \
--cc=alsa-devel@alsa-project.org \
--cc=fabio.estevam@freescale.com \
--cc=lgirdwood@gmail.com \
--cc=nicoleotsuka@gmail.com \
--cc=sachin.kamat@samsung.com \
--cc=timur@tabi.org \
--cc=tiwai@suse.de \
--cc=xobs@kosagi.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox