From: Mark Brown <broonie@kernel.org>
To: Vinod Koul <vinod.koul@intel.com>
Cc: alsa-devel@alsa-project.org, subhransu.s.prusty@intel.com,
lgirdwood@gmail.com
Subject: Re: [PATCH v4 2/7] ASoC: Intel: mrfld - Add DSP load and management
Date: Fri, 17 Oct 2014 11:44:14 +0200 [thread overview]
Message-ID: <20141017094413.GF3771@sirena.org.uk> (raw)
In-Reply-To: <1413469819-18775-3-git-send-email-vinod.koul@intel.com>
[-- Attachment #1.1: Type: text/plain, Size: 701 bytes --]
On Thu, Oct 16, 2014 at 08:00:14PM +0530, Vinod Koul wrote:
> +static void memcpy32_toio(void __iomem *dst, const void *src, int count)
> +{
> + int i;
> + const u32 *src_32 = src;
> + u32 *dst_32 = dst;
> +
> + for (i = 0; i < count/sizeof(u32); i++)
> + writel(*src_32++, dst_32++);
> +}
We also have a memcpy32_toio in atmel_nand.c which I pointed out before
and now another in mxc_nand.c. All of which use different writel
variants. This isn't awesome, we should at least try to clean this up
rather than add another duplicate - by the time we're onto the third
user there's a clear need for something generic. Do you have any
thoughts on dealing with this?
Otherwise the patch looks good.
[-- Attachment #1.2: Digital signature --]
[-- Type: application/pgp-signature, Size: 473 bytes --]
[-- Attachment #2: Type: text/plain, Size: 0 bytes --]
next prev parent reply other threads:[~2014-10-17 9:44 UTC|newest]
Thread overview: 25+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-10-16 14:30 [PATCH v4 0/7] ASoC: Intel: sst - add the merrifield IPC driver Vinod Koul
2014-10-16 14:30 ` [PATCH v4 1/7] ASoC: Intel: mrfld - add the dsp sst driver Vinod Koul
2014-10-17 9:11 ` Mark Brown
2014-10-16 14:30 ` [PATCH v4 2/7] ASoC: Intel: mrfld - Add DSP load and management Vinod Koul
2014-10-17 9:44 ` Mark Brown [this message]
2014-10-17 9:18 ` Vinod Koul
2014-10-17 10:04 ` Takashi Iwai
2014-10-17 12:01 ` Mark Brown
2014-10-17 12:07 ` Takashi Iwai
2014-10-20 5:41 ` Vinod Koul
2014-10-20 15:29 ` Mark Brown
2014-10-20 16:07 ` Vinod Koul
2014-10-16 14:30 ` [PATCH v4 3/7] ASoC: Intel: sst - add pcm ops handling Vinod Koul
2014-10-17 12:07 ` Mark Brown
2014-10-17 11:35 ` Vinod Koul
2014-10-16 14:30 ` [PATCH v4 4/7] ASoC: Intel: sst: Add IPC handling Vinod Koul
2014-10-17 12:09 ` Mark Brown
2014-10-17 11:55 ` Vinod Koul
2014-10-17 13:53 ` Mark Brown
2014-10-20 5:18 ` Vinod Koul
2014-10-16 14:30 ` [PATCH v4 5/7] ASoC: Intel: sst: add stream operations Vinod Koul
2014-10-16 14:30 ` [PATCH v4 6/7] ASoC: Intel: sst: Add some helper functions Vinod Koul
2014-10-16 14:30 ` [PATCH v4 7/7] ASoC: Intel: sst: Add makefile and kconfig changes Vinod Koul
2014-10-17 12:15 ` [PATCH v4 0/7] ASoC: Intel: sst - add the merrifield IPC driver Mark Brown
2014-10-17 11:56 ` Vinod Koul
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20141017094413.GF3771@sirena.org.uk \
--to=broonie@kernel.org \
--cc=alsa-devel@alsa-project.org \
--cc=lgirdwood@gmail.com \
--cc=subhransu.s.prusty@intel.com \
--cc=vinod.koul@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox