From: Mark Brown <broonie@kernel.org>
To: Fabio Estevam <festevam@gmail.com>
Cc: "alsa-devel@alsa-project.org" <alsa-devel@alsa-project.org>,
Jonathan Bennett <jbscience87@gmail.com>,
Nicolin Chen <nicoleotsuka@gmail.com>,
Aaron Kling <webgeek1234@gmail.com>,
Igor Grinberg <grinberg@compulab.co.il>,
Valentin Raevsky <valentin@compulab.co.il>
Subject: Re: Request for comments for SND_SOC_IMX_WM8731
Date: Fri, 24 Oct 2014 15:04:40 +0100 [thread overview]
Message-ID: <20141024140440.GG3729@sirena.org.uk> (raw)
In-Reply-To: <CAOMZO5AXhj-r4v-sR6Rp_ywD85M07W06r551vMq0r6juE+Tmgg@mail.gmail.com>
[-- Attachment #1.1: Type: text/plain, Size: 955 bytes --]
On Fri, Oct 24, 2014 at 10:20:29AM -0200, Fabio Estevam wrote:
> On Fri, Oct 24, 2014 at 2:42 AM, Jonathan Bennett <jbscience87@gmail.com> wrote:
> > + ssi_clk = devm_clk_get(&codec_dev->dev, "cko");
> > + if (IS_ERR(ssi_clk)) {
> > + pr_err("Could not get \"cko\" clock \n");
> > + return PTR_ERR(ssi_clk);
>
> I am not sure that adding the clock handling here is the correct approach.
>
> The dts you use looks like:
>
> codec: wm8731@1a {
> compatible = "wlf,wm8731";
> reg = <0x1a>;
> clocks = <&clks 173>, <&clks 158>, <&clks 201>, <&clks 200>;
> clock-names = "pll4", "imx-ssi.1", "cko", "cko2";
> ,which does not match the current bindings for the wm8731. The wm8731
> driver could be extended to handle the clocks if needed, instead of
> handling them via machine driver.
The WM8731 doesn't have anything like that number of clock inputs so
hanging them off the WM8731 seems very confused.
[-- Attachment #1.2: Digital signature --]
[-- Type: application/pgp-signature, Size: 473 bytes --]
[-- Attachment #2: Type: text/plain, Size: 0 bytes --]
next prev parent reply other threads:[~2014-10-24 14:04 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-10-24 4:42 Request for comments for SND_SOC_IMX_WM8731 Jonathan Bennett
2014-10-24 12:20 ` Fabio Estevam
2014-10-24 14:04 ` Mark Brown [this message]
2014-10-24 14:10 ` Fabio Estevam
2014-10-24 14:48 ` Jonathan Bennett
2014-10-24 14:56 ` Fabio Estevam
2014-10-24 15:09 ` Fabio Estevam
2014-10-24 16:19 ` Mark Brown
2014-10-24 16:33 ` Jonathan Bennett
2014-10-24 16:36 ` Mark Brown
2014-10-26 7:40 ` Nicolin Chen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20141024140440.GG3729@sirena.org.uk \
--to=broonie@kernel.org \
--cc=alsa-devel@alsa-project.org \
--cc=festevam@gmail.com \
--cc=grinberg@compulab.co.il \
--cc=jbscience87@gmail.com \
--cc=nicoleotsuka@gmail.com \
--cc=valentin@compulab.co.il \
--cc=webgeek1234@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox