From: Dan Carpenter <dan.carpenter@oracle.com>
To: sudipm.mukherjee@gmail.com
Cc: alsa-devel@alsa-project.org
Subject: Re: ALSA: echoaudio: remove all snd_printk
Date: Tue, 4 Nov 2014 19:01:56 +0300 [thread overview]
Message-ID: <20141104160156.GA15854@mwanda> (raw)
Hello Sudip Mukherjee,
The patch b5b4a41b3929: "ALSA: echoaudio: remove all snd_printk" from
Nov 3, 2014, leads to the following static checker warning:
sound/pci/echoaudio/echoaudio.c:1908 snd_echo_free()
error: dereferencing freed memory 'chip'
sound/pci/echoaudio/echoaudio.c
1905 /* release chip data */
1906 free_firmware_cache(chip);
1907 kfree(chip);
^^^^^^^^^^^
1908 dev_dbg(chip->card->dev, "Chip freed.\n");
^^^^^^^^^^
We have lots of printks in this function. We could just delete them all
and no one would care. These days you can get the same information from
ftrace.
1909 return 0;
1910 }
regards,
dan carpenter
next reply other threads:[~2014-11-04 16:02 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-11-04 16:01 Dan Carpenter [this message]
2014-11-04 16:15 ` ALSA: echoaudio: remove all snd_printk Takashi Iwai
2014-11-04 17:11 ` Sudip Mukherjee
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20141104160156.GA15854@mwanda \
--to=dan.carpenter@oracle.com \
--cc=alsa-devel@alsa-project.org \
--cc=sudipm.mukherjee@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox