From: Vinod Koul <vinod.koul@intel.com>
To: Lars-Peter Clausen <lars@metafoo.de>
Cc: alsa-devel@alsa-project.org, patches@opensource.wolfsonmicro.com,
Liam Girdwood <lgirdwood@gmail.com>,
Mark Brown <broonie@kernel.org>, Dan Murphy <dmurphy@ti.com>,
Charles Keepax <ckeepax@opensource.wolfsonmicro.com>
Subject: Re: [PATCH 1/6] ASoC: sn95031: Use table based control setup
Date: Wed, 5 Nov 2014 17:42:38 +0530 [thread overview]
Message-ID: <20141105121238.GM1870@intel.com> (raw)
In-Reply-To: <1415180796-31129-1-git-send-email-lars@metafoo.de>
On Wed, Nov 05, 2014 at 10:46:31AM +0100, Lars-Peter Clausen wrote:
> Makes the code a bit cleaner.
Looks good to me,
Acked-by: Vinod Koul <vinod.koul@intel.com>
--
~Vinod
>
> Signed-off-by: Lars-Peter Clausen <lars@metafoo.de>
> ---
> sound/soc/codecs/sn95031.c | 6 +++---
> 1 file changed, 3 insertions(+), 3 deletions(-)
>
> diff --git a/sound/soc/codecs/sn95031.c b/sound/soc/codecs/sn95031.c
> index cf8fa40..6167c59 100644
> --- a/sound/soc/codecs/sn95031.c
> +++ b/sound/soc/codecs/sn95031.c
> @@ -867,9 +867,6 @@ static int sn95031_codec_probe(struct snd_soc_codec *codec)
> snd_soc_write(codec, SN95031_SSR2, 0x10);
> snd_soc_write(codec, SN95031_SSR3, 0x40);
>
> - snd_soc_add_codec_controls(codec, sn95031_snd_controls,
> - ARRAY_SIZE(sn95031_snd_controls));
> -
> return 0;
> }
>
> @@ -886,6 +883,9 @@ static struct snd_soc_codec_driver sn95031_codec = {
> .remove = sn95031_codec_remove,
> .set_bias_level = sn95031_set_vaud_bias,
> .idle_bias_off = true,
> +
> + .controls = sn95031_snd_controls,
> + .num_controls = ARRAY_SIZE(sn95031_snd_controls),
> .dapm_widgets = sn95031_dapm_widgets,
> .num_dapm_widgets = ARRAY_SIZE(sn95031_dapm_widgets),
> .dapm_routes = sn95031_audio_map,
> --
> 1.8.0
>
--
next prev parent reply other threads:[~2014-11-05 12:12 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-11-05 9:46 [PATCH 1/6] ASoC: sn95031: Use table based control setup Lars-Peter Clausen
2014-11-05 9:46 ` [PATCH 2/6] ASoC: tas2552: Use table based DAPM setup Lars-Peter Clausen
2014-11-05 9:46 ` [PATCH 3/6] ASoC: wl1273: Use table based control setup Lars-Peter Clausen
2014-11-05 9:46 ` [PATCH 4/6] ASoC: wm8737: Use table based DAPM and " Lars-Peter Clausen
2014-11-05 14:21 ` Charles Keepax
2014-11-05 9:46 ` [PATCH 5/6] ASoC: wm8961: " Lars-Peter Clausen
2014-11-05 14:22 ` Charles Keepax
2014-11-05 9:46 ` [PATCH 6/6] ASoC: wm8995: " Lars-Peter Clausen
2014-11-05 14:22 ` Charles Keepax
2014-11-05 12:12 ` Vinod Koul [this message]
2014-11-05 14:50 ` [PATCH 1/6] ASoC: sn95031: Use table based " Mark Brown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20141105121238.GM1870@intel.com \
--to=vinod.koul@intel.com \
--cc=alsa-devel@alsa-project.org \
--cc=broonie@kernel.org \
--cc=ckeepax@opensource.wolfsonmicro.com \
--cc=dmurphy@ti.com \
--cc=lars@metafoo.de \
--cc=lgirdwood@gmail.com \
--cc=patches@opensource.wolfsonmicro.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox