From mboxrd@z Thu Jan 1 00:00:00 1970 From: Charles Keepax Subject: Re: [PATCH 01/32] ASoC: wm8350: Cleanup manual bias level transitions Date: Mon, 24 Nov 2014 10:00:10 +0000 Message-ID: <20141124100010.GA13764@opensource.wolfsonmicro.com> References: <1416746269-4935-1-git-send-email-lars@metafoo.de> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: Received: from opensource.wolfsonmicro.com (opensource.wolfsonmicro.com [80.75.67.52]) by alsa0.perex.cz (Postfix) with ESMTP id AB085260490 for ; Mon, 24 Nov 2014 11:00:11 +0100 (CET) Content-Disposition: inline In-Reply-To: <1416746269-4935-1-git-send-email-lars@metafoo.de> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: alsa-devel-bounces@alsa-project.org Sender: alsa-devel-bounces@alsa-project.org To: Lars-Peter Clausen Cc: alsa-devel@alsa-project.org, Mark Brown , Liam Girdwood , patches@opensource.wolfsonmicro.com List-Id: alsa-devel@alsa-project.org On Sun, Nov 23, 2014 at 01:37:17PM +0100, Lars-Peter Clausen wrote: > Set the CODEC driver's suspend_bias_off flag rather than manually going to > SND_SOC_BIAS_OFF in suspend and SND_SOC_BIAS_STANDBY in resume. This makes > the code a bit shorter and cleaner. > > Since the ASoC core now takes care of setting the bias level to > SND_SOC_BIAS_OFF when removing the CODEC there is no need to do it manually > anymore either. > > The manual transition to SND_SOC_BIAS_STANDBY at the end of CODEC probe() > can also be removed as the core will automatically do this after the CODEC > has been probed. > > Signed-off-by: Lars-Peter Clausen > --- Whole series looks good to me: Acked-by: Charles Keepax Thanks, Charles